Add reso versioning #182
Merged
Add reso versioning #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should be able to alter the version of the RESO Web API we are hitting. This change should allow for that using the already existing `version` configuration option. That option was initially spark-only since the RESO Web API did not exist yet.
dgmyrek
reviewed
Nov 7, 2022
lib/spark_api/request.rb
Outdated
| @@ -83,7 +83,7 @@ def request(method, path, body, options) | |||
| request_opts.merge!(options) | |||
| request_path = if middleware && middleware.to_sym == :reso_api | |||
| dd_version = "Dictionary/#{dictionary_version}/" unless dictionary_version.nil? | |||
| "/Reso/#{dd_version}OData#{path}" | |||
| "/Version/#{version}/Reso/#{dd_version}OData#{path}" | |||
There was a problem hiding this comment.
Does setting the :reso_api flag set a different default version than the Spark API's "v1"?
I'm wondering if the default value of this variable needs to be updated on the fly to be compatible with this new RESO API code path:
spark_api/lib/spark_api/configuration.rb
Line 37 in 8500003
There was a problem hiding this comment.
I agree, @dgmyrek. The way this was built was to take into account that parameter under all circumstances. Instead of having a computed default, I opted to ignore this parameter unless it is not the default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should be able to alter the version of the RESO Web API we are
hitting. This change should allow for that using the already existing
versionconfiguration option. That option was initially spark-onlysince the RESO Web API did not exist yet.