#869 [Refactor] Docker 이미지 사이즈 줄이기 #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
✅ Deploy Preview for taxi-dev-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
yumincho
reviewed
Mar 7, 2025
| @@ -3,7 +3,7 @@ server { | |||
| listen [::]:80; | |||
|
|
|||
| location ~ ^/invite/(?<room_id>[^/]+) { | |||
| root /root/serve; | |||
| root /app/serve; | |||
There was a problem hiding this comment.
Nginx를 사용하기 위해 chmod +x를 해야 하는데, 이를 /root에서 실행하기보다 필요한 파일만 존재하는 디렉토리에 실행하는 것이 낫다고 생각하였습니다.
Comment on lines
+11
to
+16
| ARG FRONT_URL | ||
| ARG BACK_URL | ||
| ARG OG_IMAGE_URL | ||
| ENV REACT_APP_FRONT_URL=$FRONT_URL | ||
| ENV REACT_APP_BACK_URL=$BACK_URL | ||
| ENV REACT_APP_OG_URL=$OG_IMAGE_URL |
There was a problem hiding this comment.
Multi-stage builds를 사용할 경우 stage마다 ARG를 다시 선언해야 합니다. (Ref.)
Build arguments declared in the global scope of a Dockerfile aren't automatically inherited into the build stages. They're only accessible in the global scope.
kmc7468
changed the title
kmc7468
approved these changes
Mar 13, 2025
|
ㅋㅋㅋㅋㅋㅋ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It closes #869
Multi-stage builds 이용해 사이즈를 2.99GB → 256MB로 줄였습니다. (약 91% 감소)
ECR에 표시되는 기존 이미지의 사이즈는 1,136MB인데, 이는 압축된 크기입니다. (Ref.)
빌드 시간이 단축되었습니다.
AS-IS
TO-BE
pnpm build시tsc와vite가 사용되기 때문에pnpm fetch,pnpm install시--prodflag를 사용하지 않았습니다.Images or Screenshots
Further Work
--prodflag를 사용하면 빌드 시간을 더욱 단축할 수 있습니다.