Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2025 새학기 이벤트 : 랜덤박스 모달 수정 #867

Merged
merged 2 commits into from
Mar 9, 2025

Conversation

malloc3141
Copy link
Contributor

@malloc3141 malloc3141 commented Feb 27, 2025

Summary

It closes #866
키보드 때문에 구매 수량이 가려지는 문제를 해결하기 위해 input의 위치를 바꿨습니다
또한 100 이하의 수가 입력되면 자동으로 100으로 replace되던 것을 없애고, 대신 100의 배수가 아닐 경우 구매가 안 눌리도록 변경하였습니다.

Images or Screenshots

image

Further Work

  • Do something...

@malloc3141 malloc3141 added 😱 bug Something isn't working event labels Feb 27, 2025
@malloc3141 malloc3141 self-assigned this Feb 27, 2025
Copy link

netlify bot commented Feb 27, 2025

Deploy Preview for taxi-dev-preview ready!

Name Link
🔨 Latest commit 368aa6f
🔍 Latest deploy log https://app.netlify.com/sites/taxi-dev-preview/deploys/67cd63769763210008b6a1b2
😎 Deploy Preview https://deploy-preview-867--taxi-dev-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kmc7468
Copy link
Member

kmc7468 commented Mar 6, 2025

dashed line 추가된 걸로 알고 있는데 혹시 스크린샷 업데이트해 주실 수 잇을까용??

@malloc3141 malloc3141 requested a review from kmc7468 March 9, 2025 09:46
Copy link
Member

@kmc7468 kmc7468 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@malloc3141 malloc3141 merged commit 9253149 into dev Mar 9, 2025
4 checks passed
@malloc3141 malloc3141 deleted the 866-fix-randombox-modal branch March 9, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
😱 bug Something isn't working event
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] 2025 새학기 이벤트 : 랜덤박스 모달 관련 버그
2 participants