Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set BAT_INDEX as uint16 in example code #64

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Conversation

der-eismann
Copy link
Contributor

This just cost me around 30 minutes because I couldn't figure out why the example code wasn't working, I always got this:

ERRO[0000] message at index 0: expected *uint16 got int : value does not match data type

And then even when I tried to pass a *uint16 as requested, I got

ERRO[0000] message at index 0: expected *uint16 got *uint16 : value does not match data type

so maybe the error message could use some improvements as well.

But most important is to set the value as uint16 and the example will work.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.83%. Comparing base (5494bd8) to head (dbfc5e8).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #64   +/-   ##
=======================================
  Coverage   47.83%   47.83%           
=======================================
  Files          28       28           
  Lines        1315     1315           
=======================================
  Hits          629      629           
  Misses        652      652           
  Partials       34       34           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spali
Copy link
Owner

spali commented Oct 21, 2024

Thanks for your contribution, I know, the errors are very generic... but thats because the code is very generic and I didn't had the time to implement the proper error handling in a more user friendly way.

@spali spali merged commit 426e493 into spali:master Oct 21, 2024
6 checks passed
@der-eismann
Copy link
Contributor Author

No problem, I'm happy that there's actually a usable library! Thanks for creating and sharing it 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants