Fix python3 compatibility bug in spack edit command #6748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Regarding
I think the easiest way to get better coverage is to mock |
ch741
pushed a commit
to ch741/spack
that referenced
this pull request
Apr 20, 2018
In Python 2, filter() returns a list, but in Python 3, filter() returns an iterator, and iterators have no length.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a Python 3 compatibility bug introduced by #6416.
When run with Python 3, I get the following error message:
In Python 2,
filter()returns a list, but in Python 3,filter()returns an iterator, and iterators have no length.@becker33
P.S. Thoughts on how to write unit tests for
spack edit? We're currently getting 37% coverage...