Fix performance issue on macOS #48997

alalazo · 2025-02-11T16:27:03Z

Introduced in #48729 archspec.cpu.host() is not memoized, so compute it as less as possible.

archspec.cpu.host() is not memoized, so compute it as less as possible.

alalazo · 2025-02-11T16:30:29Z

@spackbot fix style

spackbot-app · 2025-02-11T16:30:32Z

Let me see if I can fix that for you!

spackbot-app · 2025-02-11T16:31:36Z

I was able to run spack style --fix for you!

spack style --fix

==> Running style checks on spack
  selected: import, isort, black, flake8, mypy
==> Modified files
  lib/spack/spack/solver/input_analysis.py
==> Running import checks
import check requires Python 3.9 or later
  import checks were clean
==> Running isort checks
  isort checks were clean
==> Running black checks
reformatted lib/spack/spack/solver/input_analysis.py
All done! ✨ 🍰 ✨
1 file reformatted.
  black checks were clean
==> Running flake8 checks
  flake8 checks were clean
==> Running mypy checks
lib/spack/spack/version/version_types.py:134: error: Incompatible types in assignment (expression has type "Tuple[Any, ...]", variable has type "Tuple[str]")  [assignment]
lib/spack/spack/variant.py:130: error: Unsupported right operand type for in ("Union[Collection[Any], Callable[..., Any]]")  [operator]
lib/spack/spack/build_environment.py:171: error: Overloaded function signatures 1 and 2 overlap with incompatible return types  [misc]
lib/spack/spack/build_environment.py:171: error: Overloaded function signatures 1 and 3 overlap with incompatible return types  [misc]
Found 4 errors in 3 files (checked 636 source files)
  mypy found errors

Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. If I was able to push to your branch, if you make further changes you will need to pull from your updated branch before pushing again.

I've updated the branch with style fixes.

alalazo · 2025-02-11T17:53:59Z

Self-merging as a hotfix.

archspec.cpu.host() is not memoized, so compute it as less as possible. --------- Co-authored-by: alalazo <alalazo@users.noreply.github.com>

* damaris: add v1.12.0, update maintainers (#48674) Co-authored-by: Etienne Ndamlabin <jean-etienne.ndamlabin-mboula@inria.fr> * Bump up the version for rocm-6.3.1 release (#48440) This PR updates the versions for the rocm recipes for rocm-6.3.1 release. * py-flash-attn: add missing triton dependency (#48645) * hep stack: additional event generator packages (#48565) * hep stack: additional event generator packages * hep: adidtional packages * hep: collier doesn't have +pic +shared * py-awkward-cpp: fix scikit-build-core range of applicability * hep: disable agile * hep: disable garfieldpp and genie * py-wxpython: depends_on pkgconfig even if using external wxwidgets * hep: disable professor * papi: fix error finding gmake during post-install testing (#48592) * JAX: add v0.4.32+ (#46346) * JAX: add v0.4.34 * Disable search for clang * Update CUDA flags * Add py-jax 0.4.33, comment out until py-jaxlib 0.4.33 is also released * Fix GCC build * Try TF_NVCC_CLANG * py-jax: add v0.4.34 * jax no longer has separate tags for jaxlib * Install compiled wheel * Join path before glob * Wheel is in spack stage, not tmp path * Add 0.4.35 * Add newer versions * Build system has been refactored yet again * Drop clang * Fix build with source tarball, rocm support * Support GCC * Remove clang-specific compiler flags * enable_cuda flag was removed * Fix logic * py-jax: add v0.4.38 * Add patch to fix GCC support * Patch no longer needed * Skip patching, directly pass flags * New flags * Remove unused import * Patch changed * Use older version of patch * Newer patch * Add CUDA symlink * Symlink more directories * Recursive symlink * Import function * Recursive search * Undo cuda changes * Add v0.5.0 * I quit * py-geemap: add new package (#48602) * easi: add v1.5.1; relax yaml-cpp and lua requirements (#48675) * thepeg: extend the rivet@:3 dependency up to version 2.3 (#48691) Co-authored-by: jmcarcell <jmcarcell@users.noreply.github.com> * py-ipyrad: adding version 0.9.102 (#48686) Signed-off-by: Shane Nehring <snehring@iastate.edu> * autodock-vina: adding version 1.2.6 (#48684) Signed-off-by: Shane Nehring <snehring@iastate.edu> * toybox: add v0.8.12 (#48657) * Changes for NVIDIA HPC SDK 25.1 (#48696) * update hypre version and add new memalign for petsc (#47831) * petsc+rocm: add dependency on hipblas-common (#48644) * spec.py: fix ArchSpec.intersects (#48741) fixes a bug where `x86_64:` and `ppc64le:` intersected, and x86_64: and :haswell did not. * ucx: adding 1.18.0 (#48742) * Adding UCX 1.18.0 * Verified and correct hash. * MAGMA: add v2.9.0 (#48750) * Deprecate frontend/backend os/target (#47756) * package api: drop wildcard re-export (#48760) * package api: drop wildcard re-export To ensure package repos are forward/backward compatibility with Spack, we should explicitly export all symbols we want to expose in the public package API, and drop `from spack.something import *` because removal/addition to the public API will go unnoticed. Also `llnl.util.filesystem` has some methods that shouldn't be exposed in the package API, so better to enumerate a subset explicitly. * remove flatten_dependencies / install_dependency_symlinks * py-cmake: remove. remove deprecated cmake versions (#48763) * Remove pipelines and images based on ppc64le (#48767) * petsc: only conflict with kokkos@4.5: if it is enabled (#48698) * hpctoolkit: Add `+docs` variant and manpages (#48566) * py-mdit-py-plugins: Add new versions 0.3.5, 0.4.2 Signed-off-by: Jonathon Anderson <anderson.jonathonm@gmail.com> * py-myst-parser: Add new versions 0.19.0 to 4.0.0 Signed-off-by: Jonathon Anderson <anderson.jonathonm@gmail.com> * hpctoolkit: Add +docs variant and manpages This commit unconditionally enables manpages for the HPCToolkit tools. The new `+docs` variant enables additional documentation, specifically the user's manual. Both require new build-time dependencies. Signed-off-by: Jonathon Anderson <anderson.jonathonm@gmail.com> --------- Signed-off-by: Jonathon Anderson <anderson.jonathonm@gmail.com> * fmt: simplify +pic (#48766) Co-authored-by: Harmen Stoppels <harmenstoppels@gmail.com> * Docs/bugfix: correct return for Adding flags to configure (#48434) * binutils: conflict on configuration with build issues (#42949) * Create SALT package.py (#48758) * Create SALT package.py Added a package for the SALT Source AnaLysis Toolkit @zbeekman * [@spackbot] updating style on behalf of wspear * Update package.py Line wrap --------- Co-authored-by: wspear <wspear@users.noreply.github.com> * smee-client: add v2.0.4 (#48384) * CMake: add v3.31.5, v3.30.7 (#48759) * builtin: remove redundant imports (#48765) * builtin: remove redundant llnl.util.filesystem import * remove redundant import spack.version * unsorted fixes * more spack.version * abinit: pass flag correctly (#48788) * Add py-zarr 3, which includes a new required package py-donfig, and a bug fix to the patch range with numcodecs (#48786) * libxc: add CMake builder (#48772) * libsmeagol * libxc cmake * cmake support * revert changes * make spackbot happy * fix * Update package.py * hipblaslt: update cmake dependency (#48637) * hipblaslt: update cmake dependency 1 error found in build log: >> 3 CMake Error at CMakeLists.txt:24 (cmake_minimum_required): 4 CMake 3.25.2 or higher is required. You are running version 3.22.1 5 6 7 -- Configuring incomplete, errors occurred! See build log for details: /scratch/svcpetsc/spack-rocm/spack-stage/spack-stage-hipblaslt-6.3.0-pabb7t4rheqkz74lfzbsnqi6vnpiqwlq/spack-build-out.txt * Update var/spack/repos/builtin/packages/hipblaslt/package.py Co-authored-by: afzpatel <122491982+afzpatel@users.noreply.github.com> --------- Co-authored-by: afzpatel <122491982+afzpatel@users.noreply.github.com> * Move from python2 compliant IOError and EnvironmentError to python3-only OSError (#48764) * IOError -> OSError * also do EnvironmentError * py-sphinx: mark Python compatibility (#48796) * spack.package: wrap llnl.util.tty (#48793) avoid import of llnl.util.tty in packages * spack.package: re-export EnvironmentModifications / Prefix (#48792) * Remove unused values (#48795) Signed-off-by: Todd Gamblin <tgamblin@llnl.gov> Co-authored-by: Todd Gamblin <tgamblin@llnl.gov> * petsc, py-petsc4py: add v3.22.3 (#48785) * libsmeagol (#48776) * libsmeagol * add support for intel and add conflicts * cp2k * Bug Fix: Better incremental check for CMake (#48775) * Bug Fix: Better incremental check for CMake * Fix syntax error * Ensure match of config artifact with generator * add cdo@2.5.0 (#48801) * Added salt variant to tau (#48782) * Added salt variant to tau * Update package.py * [@spackbot] updating style on behalf of wspear --------- Co-authored-by: wspear <wspear@users.noreply.github.com> * Remove patch on main (#48798) Patch got merged: https://github.com/natefoo/slurm-drmaa/pull/62 * kokkos-nvcc-wrapper: add version 4.5.00 and 4.5.01 (#48802) * env create: create copies of relative include files in envs created from manifest (#48689) Currently, environments created from manifest files with relative includes result in broken references to config files. This PR modifies `spack env create` to create local copies in the new environment of any local config files from relative paths in the environment manifest passed as an init file. This PR does not change the behavior if the include is an absolute path or if the include is from a relative path outside the environment directory, but it does warn about missing relative includes if they are inside the environment directory. Includes regression test and short blurb in docs. * py-sphinx-rtd-theme: add v2.0.0, v3.0.0 (#48756) * Add versions 2 and 3 of py-sphinx-rtd-theme. Allow for versions of py-sphinx greater than 6. Fix the Python version for older versions that depend on distutils. Get the py-docutils dependency from the py-sphinx recipe. * Depend purely on the py-docutils dependency in py-sphinx. * More refined dependency versioning. * Fixed versioning for py-sphinx and py-docutils. * CP2K: add 2025.1 version and DFTD4 support (#48489) * cp2k: add dftd4 variant * better conflict and make support * typo * Update var/spack/repos/builtin/packages/cp2k/package.py * Update var/spack/repos/builtin/packages/cp2k/package.py * oci/opener.py: respect system proxy settings (#48783) * vtk-m: CMAKE_CXX_COMPILER is not a BOOL (#48813) * gcc: remove --with-ld=ld-classic (#48826) * nanotron: add new package (#48582) * nanotron: add new package Also, update some dependencies and add missing ones. * Add variant +examples needed to execute example scripts * fix: add missing branch attribute * Remove master version * fix: use Github hash * embree: fix tests by building tutorial's embree_viewer for tests (#48392) * import-check: improve how problematic imports are displayed (#48825) The import-check action now presents problematic import statements introduced by the PR better. The idea is roughly: * Let (V₁, E₁) be the graph of modules as vertices and import statements as edges before the change * Let (V₂, E₂) be the graph after the code change, which is typically a small perturbation of (V₁, E₁). * X₁ = FAS(V₁, E₁) is the feedback arc set before (a minimal set of edges to delete to make it acyclic) * X₂ = FAS(V₂, E₂ ∖ X₁) is the feedback arc set after deletion of the minimal set of edges that made the old graph acyclic. * X₃ = FAS(V₂, E₂) is the feedback arc set after Previously I displayed X₁ and X₃ and users had to diff themselves. Now, I'm showing X₂, which is a small set, typically directly related to code changes. However, it can be that a small code change adding say 2 problematic imports creates a completely different solution X₃ that only requires deletion of just 1 different import. In that case the user is informed that they can potentially do less work. So for PR #48784 the output is now: > The overall number of problematic import statements increased by 1 from 31 to 32. > This is likely a direct consequence of the following import statements: > > ``` > spack/config imports: spack.spec, spack.util.path, spack.util.remote_file_cache > ``` > > However, instead of removing 3 import statements, it is sufficient to remove only 1 > import statement from the following list: > > ``` > spack/concretize imports: spack.bootstrap, spack.solver.asp > spack/environment imports: spack.bootstrap, spack.environment > spack/fetch_strategy imports: spack.version.git_ref_lookup > spack/install_test imports: spack.build_environment, spack.package_base > spack/modules imports: spack.modules > spack/platforms imports: spack.config > spack/relocate imports: spack.bootstrap > spack/repo imports: spack.package_base, spack.patch, spack.tag > spack/spec imports: spack.binary_distribution, spack.compiler, spack.compilers, spack.concretize, spack.environment, spack.hash_types, spack.provider_index, spack.repo, spack.spec_parser, spack.store, spack.traverse, spack.variant, spack.version.git_ref_lookup > spack/subprocess_context imports: spack.environment > spack/util/gpg imports: spack.bootstrap > spack/util/package_hash imports: spack.package_base > spack/util/path imports: spack.config, spack.environment > spack/util/remote_file_cache imports: spack.util.web > ``` from which the user can figure out that `spack/util/remote_file_cache imports: spack.util.web` is the "bottleneck" now. * spack_yaml: use unambiguous variable name (#48832) * style: fix `not in` and `is not` (#48831) These are some changes that `ruff check --fix` would make that the current `spack style` also agrees with. Make the changes now so that the `ruff` change is less disruptive. Signed-off-by: Todd Gamblin <tgamblin@llnl.gov> * Set version to v1.0.0.dev0 (#48791) * import-check: enable color output (#48842) * berkeleygw: add -o flag to tar extraction (#48816) when extracting as root user, avoid that tar attempts to change file ownership * llvm: deprecate old patch releases (#48762) * cuda: add v12.8 (#48708) * sirius: patch pugixml (#48841) * ziatest: add new package (#48809) * gitlab: remove isc stacks (#48811) * gcc: deprecate old patch releases (#48761) * CP2K: use libxc@7 for master/next release (#48808) * packge_base.py: remove _patches_by_hash (#48768) * cdash: avoid build_opener (#48846) * g4vg: new package (#48844) * g4vg: new package * [@spackbot] updating style on behalf of sethrj * r-dmrcate: add v2.16.0, v3.0.0, v3.2.0 (#48158) * r-dmrcate: add new versions * r-dmrcate: require `r@4.3.0` for v2.99.0+ * r-dmrcate: update dependencies * py-tensorflow: add 2.18.0-rocm-enhanced (#48711) * py-tensorflow: add 2.18.0-rocm-enhanced * fix style * fix style * fix style * review changes * review changes * remove hipblaslt dependency * remove ci changes and force ROCm 6.3.1 for newest TF * remove rocm 6.3.1 dependency * simplify configure fix * rocm-examples and rocjpeg: new packages (#47695) * new package: rocm-examples * add new package rocjpeg and update rocm-examples for 6.3.0 * fix licenses * add versions 6.3.1 * change homepage and git * add f-string * Tesseract v5.5.0 (#48866) * leptonica: adding v1.85.0 Signed-off-by: Shane Nehring <snehring@iastate.edu> * tesseract: adding v5.5.0 Signed-off-by: Shane Nehring <snehring@iastate.edu> --------- Signed-off-by: Shane Nehring <snehring@iastate.edu> * py-geojson: Add new package (#48847) * Add new package py-geojson * fix when * isa-l: add v2.31.1 (#48859) * Add new package func (#48849) * icu4c: add v75.1, v76.1 (#48858) * Add new package py-metis (#48848) * cppgsl: add v4.1.0 (#48864) * libdrm: add v2.4.124 (#48860) * amrex: add v25.02 (#48853) * sherpa: support cxxstd=20 when=@3: (#48829) * sherpa: support cxxstd=20 when=@3: * hep: sherpa cxxstd=20 * netlib-scalapack: Update version (#48667) * Update scalapack version Signed-off-by: Mathieu Taillefumier <mathieu.taillefumier@free.fr> * use url_for_version Signed-off-by: Mathieu Taillefumier <mathieu.taillefumier@free.fr> * use spec.satisfies instead of version() --------- Signed-off-by: Mathieu Taillefumier <mathieu.taillefumier@free.fr> Co-authored-by: Mathieu Taillefumier <mathieu.taillefumier@free.fr> * fcgi: add v2.4.3, v2.4.4 (#48856) * update pyproject.toml for `ruff format` (#48823) Add ruff configuration to `pyproject.toml`. This allows `ruff format` in the Spack repository to format all the files we care about, with our line length of 99, the exceptions we already put in place, and excluding things we don't auto-format, like vendored dependencies. Right now it'll reformat 175 or so files, but only slightly, in places where `ruff` differs from `black`. For the most part I like the ruff format decisions better than `black`, but none of the changes seem too severe. This does not change `spack style` -- I figure that can come later but this at least will let people start playing with `ruff`. --------- Signed-off-by: Todd Gamblin <tgamblin@llnl.gov> * dd4hep: add v1.31 (#48850) * libsm: add v1.2.5 (#48862) * Apply workaround for oneAPI compiler for upcxx problem with a template argument list (#48843) * Fix upcxx problem with a template argument list is expected after a name prefixed by the template keyword * Revert "Fix upcxx problem with a template argument list is expected after a name prefixed by the template keyword" This reverts commit faf9b8ce850dbb4c38a5019a7071415e3c6dc086. * Apply workaround for oneAPI compiler * style problem resolved * use spec.satisfies syntax --------- Co-authored-by: eugeneswalker <eugenesunsetwalker@gmail.com> * Remove ISC stacks environment files (#48851) Follow-up to #48811 * Remove variable from cmake.py (#48824) * Remove variable from cmake.py #48775 left a dangling variable that was not caught in CI but by the eyes of @haampie. Restructure variable to local method. * [@spackbot] updating style on behalf of psakievich * Update cmake.py * Update lib/spack/spack/build_systems/cmake.py * Update lib/spack/spack/build_systems/cmake.py --------- Co-authored-by: psakievich <psakievich@users.noreply.github.com> * sirius: add v7.6.2 (#48797) Co-authored-by: Mathieu Taillefumier <mathieu.taillefumier@free.fr> Co-authored-by: Rocco Meli <r.meli@bluemail.ch> * gha: standalone import-check (#48873) * ci: add codecov token secret to coverage upload job (#48880) Codecov needs to see the token secret when uploading, so we have to add this line to the workflow YAML: ```yaml with: token: ${{ secrets.CODECOV_TOKEN }} ``` Signed-off-by: Todd Gamblin <tgamblin@llnl.gov> * ci: bump import-check (#48883) * pfind: new package (#48685) * py-elevation: new package (#48836) * spec.py: fix hash change due to None vs {} (#48854) * Fix hash change due to None vs {} * Enforce null for empty list of external_modules * nnn: new package (#46174) Co-authored-by: Bernhard Kaindl <bernhardkaindl7@gmail.com> * Fix esmf usage, add new version (#48835) * bash: add autotools dependencies (#48874) * Scotch: add v7.0.6, add testing option (#48781) * code-server: update to v4.96.4 (#48828) * acts: add v39.0.0 (#48839) This commit adds version 39.0.0 of the ACTS package which, as far as I can tell, doesn't require any dependency updates. * spec.py: ensure spec.extra_attributes is {} if is null in json (#48896) * harfbuzz: add v10.2.0 (#48857) * libice: add v1.1.2 (#48861) * relocate.py: don't warn about symlinks (#48904) `relocate_links` warns when the target is absolute and not matched by any prefix from the prefix to prefix map. This can lead to false positives, cause the prefix to prefix map does not contain trivial/identity entries whenever a package is installed to its original location. Since relocate_links is the odd one out there (we don't warn about similar issues with rpaths, etc), just remove the warning. * hip-tests: new package (#47273) * hip-tests: add new package * remove hip-tests from hip recipe * remove old versions * fix style * add missing import * bump hip-tests to 6.3.1 * fix style * flecsi: new version 2.3.1 (#48867) * flecsi: add new version 2.3.1, remove develop * flecsi: remove kokkos and openmp variants moving forward * flecsi: propagate cuda and rocm settings from kokkos * Update var/spack/repos/builtin/packages/flecsi/package.py Co-authored-by: Davis Herring <herring@lanl.gov> * flecsi: remove redundant depends_on lines * flecsi: correct legion dependency * flecsi: deprecate v2.0.0 and v2.1.0 * flecsi: force +openmp if ^kokkos+openmp --------- Co-authored-by: Davis Herring <herring@lanl.gov> * Update py-arch, py-statsmodels (add 0.14.1), py-patsy (add 0.5.4) to be able to use py-cython@3 (#48769) * Add py-patsy@0.5.4 * Correct py-numpy dependency in py-arch * Add py-statsmodels@0.14.1 and update dependencies * Add climbfuji as maintainer for py-patsy * Add climbfuji as maintainer for py-statsmodels * Update var/spack/repos/builtin/packages/py-statsmodels/package.py * enzyme: add v0.0.172 (#48881) * spec.py: ensure == is false if true modulo precomputed dag hash (#48889) * llvm: fix @15 %apple-clang@16 (#48887) * spiner: add v1.6.3 (#48871) * spiner: update package logic * singularity-eos: remove spiner cuda_arch propagation * spiner: add version 1.6.3 * sherpa: +hepmc3root only when +root (#48827) * sherpa: +hepmc3root only when +root * sherpa: fix style * salt: add v0.3.0 (#48877) * salt: Add v0.3.0 of SALT This version contains important bug fixes for building and parsing projects containing Fortran * salt: Be more explicit about dependency types - llvm+clang+flang is needed at build, link and runtime for the correct operation of SALT - Testing with llvm@master ( llvm > 19.x ) shows that SALT is currently incompatible with the latest llvm API so an updated salt will be required when LLVM 20 is released * openturbine: add new package (#48683) * PyTorch: add v2.6.0 (#48794) * mummer4: patching to allow building with %gcc@13: (#38292) Co-authored-by: LMS Bioinformatics <bioinformatics@lms.mrc.ac.uk> Co-authored-by: Massimiliano Culpo <massimiliano.culpo@gmail.com> * fms: add 2025.01, 2024.03 (#48812) * py-shapely: add v2.0.7 (#48810) * spectre: add v2025.01.30 (#48803) Co-authored-by: sxs-bot <sxs-bot@users.noreply.github.com> * py-numba: Add version 0.61 (#48837) * amdfftw: fix broken build, adjust flags for performance tuning (#48754) With CFLAGS, the code path in the amdfftw build system will bypass the logic around AMD_ARCH. --------- Co-authored-by: vijay kallesh <Vijay-teekinavar.Kallesh@amd.com> * justbuild: add v1.4.3 (#48898) * nvpl-blas, nvpl-lapack: add v0.4.0.1, v0.3.0 (#48901) * hep stack: build also with cuda and rocm where possible (#48528) * lcio: add v2.22.4 (#48895) * Add a message for CMake incremental build (#48905) * Add a message for CMake incremental build Requested message to explain CMake phase is getting skipped. * [@spackbot] updating style on behalf of psakievich * Update import --------- Co-authored-by: psakievich <psakievich@users.noreply.github.com> * dcap: depends_on libxcrypt (#48903) * Add new version of r-curl (#48912) * pika: Add 0.32.0 (#48897) * icu4c: no cxxstd flag option on Windows (#48510) * ICU4C: Don't reference a spec variant on a platform on which it's not defined * icu4c: no cxx flag on Windows * dla-future-fortran: add v0.3.0 (#48900) * simgrid: add v3.36 (#48909) * dyninst: cleanup package (#47637) * Use more idiomatic construct, shorten recipe * Remove deprecated versions, and associated patches * Remove v10.0.0 * Windows: Update default config for stage location (#48511) Current location is within the Spack prefix, which causes builds to pollute VCS with stage artifacts and generally inflates the Spack install prefix. This PR moves it to the user cache location now that we can consistently support paths with spaces on Windows. * py-maturin: add v1.8.2 and refined dependencies (#48915) * clingo-bootstrap: fix +optimized build (#48931) * fix regression `apple-clang` vs `%apple-clang` * use f-strings * remove --verbose flag from LDFLAGS * Fix regression due to dyninst update (#48935) * trexio: fix issues with autotools build system (#48923) * package_base.py: remove use_cray_compiler_names (#48932) * Apply workarounds for oneAPI compiler for ascent problem with build (#48918) * Apply workarounds for oneAPI compiler for ascent problem with build * Use the way with use patch through the PR address * stylecheck - missing comma * libgcrypt: fix enforced -O0 (#48940) Signed-off-by: Shane Nehring <snehring@iastate.edu> Co-authored-by: Shane Nehring <snehring@iastate.edu> * serialbox: add version 2.6.2 (#48937) * nwchem: add master (#48919) * Add possibility to build nwchem from master branch * add oneapi@2025: patch for @7.2.3 --------- Co-authored-by: eugeneswalker <eugenesunsetwalker@gmail.com> * Python: add new versions (#48950) * Python: add new versions * black * reframe: add v4.6.4 -> v4.7.2 (#48242) * go: add v1.23.6 (#48955) * qmcpack: add v4.0.0 (#48921) * py-einops: add v0.8.1 (#48954) * flux-sched: add v0.42.1 (#48952) Co-authored-by: github-actions <github-actions@users.noreply.github.com> * Quantum ESPRESSO: add v7.4.1 (#48949) * duckdb: add v1.2.0 (#48902) Signed-off-by: Teague Sterling <teaguesterling@gmail.com> * mapl: add v2.53.1, v2.54.1 (#48944) * log.py: remove setenv calls (#48933) * nim: add v2.2.2 (#48929) * Update GFE packages (#48899) * OpenMPI: add version 4.1.8 (#48922) Signed-off-by: Howard Pritchard <howardp@lanl.gov> * extrae: tighten dependencies on boost for +dyninst (#48938) * py-iterative-stats: add 0.1.1 (#48959) * import-check: bump (#48968) * ports-of-call: add v1.6.0, v1.7.0, v1.7.1 (#48870) * acts dependencies: new versions as of 2025/02/10 (#48969) This commit adds detray v0.88.0 and GeoModel v6.9.0. * cbtf-krell: Update Boost dependency (#47133) * Update Boost * Add gotcha * Add patch for build errors * Allow building with latest Dyninst * Fix patch url * lua-sol2: Apply workaround for oneAPI compiler for problem with build (#48920) * Bump up the version for rocm-6.3.2 release (#48787) * Bump up the version for rocm-6.3.2 release * rocm-openmp-extras update and style correction * Updating mivisionx, omniperf, rccl & rocprofiler-systems * Updating hipsparselt & rocm-opencl * rocprofiler-systems on gcc-13 and rvs commit instead of patch * Updated rocjpeg & rocm-examples for 6.3.2 * ROCPROFSYS_BUILD_DYNINST & DYNINST_BUILD_TBB are required only with gcc-13 --------- Co-authored-by: afzpatel <122491982+afzpatel@users.noreply.github.com> * spack compiler find: detect `flang-new` and `flang` in newer LLVM versions (#48914) * rivet: patch missing header in 3.1.10 (#48977) * concretizer: reduce search space with static analysis (#48729) Currently, when we setup the ASP problem for `clingo`, we don't take into account the configuration. This results in setting up ASP problems that are larger than necessary, with possibly redundant information, and higher concretization times. This PR tries to improve things by adding an opt-in feature that computes the _possible dependencies_ of a solve taking also into account the current configuration, and avoids adding possible dependencies that we are certain can't be in the final solution. The feature can be activated with: ```yaml concretizer: static_analysis: true ``` Examples of simple rules to discard dependencies are: - Dependencies that are not buildable, and for which no binary is present (e.g. `cray-mpich` etc. on non Cray systems) - Dependencies that are not for the current platform (e.g. `msmpi` on non Windows platforms) - Conditional dependencies that cannot be activated, because of some user requirement (e.g. `cuda` etc. if the user requires `~cuda` in configuration) - Virtual providers that cannot be used, because of a requirement on a virtual The speed-up these rules seem to give depends on the use case at hand, but if the configuration is updated properly, they are noticeable. Since in cases where there is no rule to exclude packages upfront, reuse is active, and this option is activated, it's possible to see some minor slow down, the feature has been added as opt-in, so it's turned off by default. * spack.util.elf: catch seek errors (#48972) * hep: rivet: require hepmc=3 (#48976) * Fix performance issue on macOS (#48997) archspec.cpu.host() is not memoized, so compute it as less as possible. --------- Co-authored-by: alalazo <alalazo@users.noreply.github.com> * style.py: fix false negative in redundant import statements (#48980) * PyTorch: build flash attention by default, except in CI (#48521) * PyTorch: build flash attention by default, except in CI * Variant is boolean, only available when +cuda/+rocm * desc -> _desc * kokkos et al. : don't monkeypatch spec in callbacks (#48916) Currently, a few packages using kokkos rely on kokkos itself monkeypatching its own spec to provide some attribute. In this commit we change this attribute to be defined on the package, and never be monkeypatched. * gmake: add empty libs property, remove link deptypes from dependents (#48995) * package_hash.py: move metadata_attrs inline out of package_base (#48981) * gmake: fix def libs/headers (#49009) * Spec.package_class -> spack.repo.PATH.get_pkg_class (#48985) * libfabric: use the class variable to get the list of fabrics (#49007) Suggested by: alalazo <alalazo@users.noreply.github.com> Signed-off-by: Justin Cook <jscook@lbl.gov> * py-transformers: add new versions (#49000) * py-transformers: add new versions * py-tokenizers: add new versions * Apply suggestions from code review * lcio: Add latest 2.22.5 tag (#48991) * concretize.lp: don't warn about deprecation when external (#49008) * Spec.is_virtual -> spack.repo.PATH.is_virtual (#48986) * g4vg: add 'develop' branch (#49003) * g4vg: add develop version * celeritas: add develop version * Fix style * REVERTME: move celeritas changes to another branch * Get full repo * remove unneeded variable * Remove spack.repo.PATH.is_virtual call from SpecBuildInterface.(#48984) This PR is effectively a breaking change extracted from #45189, which removes support for spec["mpi"] if spec itself is openmpi / mpich that could provide mpi; from the Spec instance we don't have any parent it provides it to, hence it's a KeyError. * Spec.validate_detection -> spack.detection.path.validate_detection (#48987) * hep: add missing language dependencies (#48963) * highfive: add dependency on C https://gitlab.spack.io/spack/spack/-/jobs/14989283 * lhapdf: add dependency on C https://gitlab.spack.io/spack/spack/-/jobs/14989283 * vc: add dependency on C https://gitlab.spack.io/spack/spack/-/jobs/14989140 * davix: add dependency on C, C++ https://gitlab.spack.io/spack/spack/-/jobs/14989131 * pandorasdk: add dependency on C https://gitlab.spack.io/spack/spack/-/jobs/14989130 * veccore: add dependency on C https://gitlab.spack.io/spack/spack/-/jobs/14989118 * pythia6: add dependency on C https://gitlab.spack.io/spack/spack/-/jobs/14989116 * jwt-cpp: add dependency on C https://gitlab.spack.io/spack/spack/-/jobs/14989115 * collier: add dependency on C https://gitlab.spack.io/spack/spack/-/jobs/14989115 * hepmc: add dependency on C https://gitlab.spack.io/spack/spack/-/jobs/14989112 * clhep: add dependency on C https://gitlab.spack.io/spack/spack/-/jobs/14989075 * fastjet: add dependency on C https://gitlab.spack.io/spack/spack/-/jobs/14981340 * gosam-contrib: add dependency on C https://gitlab.spack.io/spack/spack/-/jobs/14978873 * thepeg: add dependency on C https://gitlab.spack.io/spack/spack/-/jobs/14997553 * cepgen: add dependency on C https://gitlab.spack.io/spack/spack/-/jobs/14997552 * podio: add dependency on C https://gitlab.spack.io/spack/spack/-/jobs/14997552 * pandoramonitoring: add dependency on C https://gitlab.spack.io/spack/spack/-/jobs/14997552 * lcio: add dependency on C https://gitlab.spack.io/spack/spack/-/jobs/14997513 * geant4: add dependency on C https://gitlab.spack.io/spack/spack/-/jobs/14997202 * evtgen: add dependency on C https://gitlab.spack.io/spack/spack/-/jobs/14996817 * apfel: add dependency on C https://gitlab.spack.io/spack/spack/-/jobs/14996779 * collier: add dependency on C, C++ https://gitlab.spack.io/spack/spack/-/jobs/14996770 * vecgeom: add dependency on C https://gitlab.spack.io/spack/spack/-/jobs/15003840 * dd4hep: add dependency on C https://gitlab.spack.io/spack/spack/-/jobs/15003839 * opendatadetector: add dependency on C https://gitlab.spack.io/spack/spack/-/jobs/15007666 * acts: add dependency on C https://gitlab.spack.io/spack/spack/-/jobs/15007827 * hepmc: remove dependency on fortran Co-authored-by: Seth R. Johnson <johnsonsr@ornl.gov> * thepeg: remove fortran dep Co-authored-by: Wouter Deconinck <wdconinc@gmail.com> * acts: add a conditional build dependency Co-authored-by: Wouter Deconinck <wdconinc@gmail.com> * opendatadetector: add comment to explain C dep Co-authored-by: Wouter Deconinck <wdconinc@gmail.com> --------- Co-authored-by: Seth R. Johnson <johnsonsr@ornl.gov> Co-authored-by: Wouter Deconinck <wdconinc@gmail.com> * apptainer: get_full_repo for branch main (#49002) * unifyfs: Apply workaround for oneAPI compiler for problem with build (#48962) * solver: add type-hints to OutputConfiguration (#48979) * Ci: ensure file path comparsion uses posix paths (#47033) Git always produces posix paths, ensure we're always comparsing apples to apples by normalizing paths compared to git output to posix. * postgresql: add v17.2 (#47811) * postgresql: add version 17.2 * postgresql: install flex, bison and perl when building versions 17 and up * postgresql: do not install perl by default when building versions 17 and up * cray-mpich: adding partial GTL support (#45830) cray-mpich now has a rocm variant. You can use gtl_lib in the flag_handler like so: ```python def flag_handler(self, name, flags): wrapper_flags = [] environment_flags = [] build_system_flags = [] if self.spec.satisfies("+rocm"): if self.spec.satisfies("^cray-mpich"): gtl_lib = self.spec["cray-mpich"].package.gtl_lib build_system_flags.extend(gtl_lib.get(name) or []) # hipcc is not wrapped, we need to pass the flags via the # build system. build_system_flags.extend(flags) return (wrapper_flags, environment_flags, build_system_flags) ``` --------- Co-authored-by: Richard Berger <rberger@lanl.gov> Co-authored-by: Massimiliano Culpo <massimiliano.culpo@gmail.com> Co-authored-by: Richard Berger <richard.berger@outlook.com> * lammps: use the Cray GTL (#46090) * lammps: add 20241119 and 20250204 releases (#48978) * plog: add new package (#48975) * binutils: add debuginfod variant + update deps (#49011) * h5hut: Remove H5_USE_110_API for newer versions (#48885) * h5hut: Remove H5_USE_110_API for newer versions * h5hut: style reformat and add maintainer * h5hut: correct version syntax for <v2.x.x * h5hut: Bump default version to 2.0.0rc7 and remove older rc candidates * Update var/spack/repos/builtin/packages/h5hut/package.py Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi> --------- Co-authored-by: Alberto Invernizzi <9337627+albestro@users.noreply.github.com> Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi> * spack debug create-db-tarball: remove after test failures (#49025) * bubblewrap: add versions up to v0.11.0 (#49023) * gftl: add v1.15.2 (#48992) * py-torchgeo: pyvista dep has been removed (#48990) * py-memray: add v1.15.0 (#48989) * yosys: add v0.50 (#48983) * laszip: Add version 3.4.4. (#48982) * py-numpy: add v2.2.3 (#49029) * pandora{pfa,sdk,monitoring}: add new versions and allow setting the C++ standard (#48300) * pandoramonitoring: add v3.6.0; pandorapfa: add v4.11.2 Remove variables that are not being used in pandorasdk. Use the C++ standard from ROOT when possible and pass -Wno-error to override the -Werror that will typically fail with a new standard. Add a cxxstd variant for pandorasdk * Fix style * Update var/spack/repos/builtin/packages/pandorasdk/package.py Co-authored-by: Wouter Deconinck <wdconinc@gmail.com> * Fix style --------- Co-authored-by: jmcarcell <jmcarcell@users.noreply.github.com> Co-authored-by: Wouter Deconinck <wdconinc@gmail.com> * easi@1.5.2 (#49013) * Put in maintainers for Kokkos Tools Spack package (#49018) * Kokkos Tools package.py: fix maintainers * Kokkos Tools package.py: remove white space between first and second maintainer in comma-separated list * [@spackbot] updating style on behalf of vlkale * Correct maintainers syntax Co-authored-by: Richard Berger <richard.berger@outlook.com> --------- Co-authored-by: vlkale <vlkale@users.noreply.github.com> Co-authored-by: Tamara Dahlgren <35777542+tldahlgren@users.noreply.github.com> Co-authored-by: Richard Berger <richard.berger@outlook.com> * zlib package: Ensure correct lib search on Windows (#48512) * Name of zlib's library differs on Windows; also account for name differing when building +shared * `zlib`'s `.libs` implementation was searching for the runtime libraries (the .dlls) and should be searching for link-time libs * Update openfast, amr-wind, and nalu-wind packages (#48994) * acts: conflicts ^geant4@11.3: when @:35 (#49028) * yq: add versions 4.44.5 and 4.44.6 and 4.45.1 (#49027) * openblas: .libs() uses self.libraries attribute (#48942) Currently this is hardcoded to the same value as listed in the class definition. If one ever overrides this attribute, such as: ``` packages: openblas: package_attributes: libraries = [ 'libopenblaso64', ] ``` this patch will make sure that override also in the `spec['openblas'].libs()` call. (Which happens in `hypre`, likely others). ( see https://spack.readthedocs.io/en/latest/packages_yaml.html#assigning-package-attributes ) Thanks to becker33 for debugging help in Slack * RepoSplit/tests: update repo tests relying on builtin package repo to only use mock repos (#48926) * RepoSplit/tests: update repo tests relying on builtin * test_repo_last_mtime: skip on windows due to mtime issues in CI * MesonPackage: depends_on pkgconfig (#46955) meson's `dependency` function often uses pkg-config to locate a dependency, and may even fall back to cmake. The former case is very common, and since packagers often forget to add the tiny pkgconfig package as a build dep, we do it for them. * Spec.__getitem__: restrict to direct deps + transitive runtime deps (#49016) With this change spec["pkg"] searches only direct dependencies and transitive link/run dependencies, ordered by depth. This avoids situations where we pick up unwanted deps of build/test deps. To reach those, you need to do spec["build_dep"]["pkg"] explicitly. Co-authored-by: Massimiliano Culpo <massimiliano.culpo@gmail.com> * views: normalize paths on case insensitive file systems (#47370) On macOS, prefix_a/file and prefix_b/FILE map to the same file view/file or view/FILE. This commit ensures that we test whether a view is created on a case insensitive filesystem and handle projection conflicts accordingly. * Allow tuning max_dupes for build dependencies (#48948) Up to now, Spack was allowing all build-tools that may appear in the DAG to have 2 max_dupes. This is not needed in practice for most of them, and adding them out of caution just increases grounding and concretization time. This PR makes the value of max_dupes configurable per package, and sets only a few known packages to 2 max_dupes by default. In case user needs different values, they can tune the configuration for their use case. * vtk: fix 9.4.1 concretization (#48946) * seacas: conflict 2024-06-27 with windows * vtk: fix 9.4.1 seacas dependency * cairo: add new version and update build system (#48822) * update cairo for new meson build system * update patch range. remove old conflict * style * update pango to reflect the changes in cairo * refine depends * style * add lzo depends * add +shared * non self-referential variant requireme * style * Move +shared variant back to just autotools as meson automatically handles it * clarify patch when= * update based on reviews. switch from conflicts to requires to enforce variant synchronization * refine conflicts and requires * better group build deps together * comment for meson build lower version bound * clarifying comments * clarify version ranges, enforce build_system with version ranges * style * cairo: no need to require for build_systems --------- Co-authored-by: Wouter Deconinck <wdconinc@gmail.com> * fzf: add v0.60.0, improve styling (#49059) * fd: improve documentation and styling to help newer maintainers (#49058) * direnv: add master, fix up package for better documentation (#49053) * GDAL: add v3.10.2 (#49042) * pbwt: new package (#49055) * pbwt: add v2.1, v2.0 Signed-off-by: Teague Sterling <teaguesterling@gmail.com> * [@spackbot] updating style on behalf of teaguesterling * Update package.py --------- Signed-off-by: Teague Sterling <teaguesterling@gmail.com> * py-xarray-regrid: Add new package (#48834) * Add py-xarray-regrid and required dep flox * remove boiler plate * Add missing py310 dep * py-flox, py-xarray-regrid: add type=("build", "run") to python dependency --------- Co-authored-by: Wouter Deconinck <wdconinc@gmail.com> * build(deps): bump isort in /.github/workflows/requirements/style (#48746) Bumps [isort](https://github.com/pycqa/isort) from 5.13.2 to 6.0.0. - [Release notes](https://github.com/pycqa/isort/releases) - [Changelog](https://github.com/PyCQA/isort/blob/main/CHANGELOG.md) - [Commits](https://github.com/pycqa/isort/compare/5.13.2...6.0.0) --- updated-dependencies: - dependency-name: isort dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump black from 24.10.0 to 25.1.0 in /lib/spack/docs (#48780) Bumps [black](https://github.com/psf/black) from 24.10.0 to 25.1.0. - [Release notes](https://github.com/psf/black/releases) - [Changelog](https://github.com/psf/black/blob/main/CHANGES.md) - [Commits](https://github.com/psf/black/compare/24.10.0...25.1.0) --- updated-dependencies: - dependency-name: black dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * surfer: new package (#48432) * Add waveform viewer, surfer for RTL simulations * Ran black over the code following style check failure * build(deps): bump black in /.github/workflows/requirements/style (#48779) Bumps [black](https://github.com/psf/black) from 24.10.0 to 25.1.0. - [Release notes](https://github.com/psf/black/releases) - [Changelog](https://github.com/psf/black/blob/main/CHANGES.md) - [Commits](https://github.com/psf/black/compare/24.10.0...25.1.0) --- updated-dependencies: - dependency-name: black dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * new package: jujutsu (#48231) * lis: add v2.0.28 -> v2.1.7 (#48308) * Added LIS 2.1.7 * Added LIS versions from 2.0.28 to 2.1.7 * apply black v25.1.0 (#49076) * build(deps): bump isort from 5.13.2 to 6.0.0 in /lib/spack/docs (#48747) Bumps [isort](https://github.com/pycqa/isort) from 5.13.2 to 6.0.0. - [Release notes](https://github.com/pycqa/isort/releases) - [Changelog](https://github.com/PyCQA/isort/blob/main/CHANGELOG.md) - [Commits](https://github.com/pycqa/isort/compare/5.13.2...6.0.0) --- updated-dependencies: - dependency-name: isort dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Spec.__contains__: restrict to direct build and transitive runtime deps (#49072) Co-authored-by: Massimiliano Culpo <massimiliano.culpo@gmail.com> * mochi-margo/mochi-thallium: new versions (#49037) * mochi-margo/mochi-thallium: new versions * mochi-thallium: fixing style * mochi-thallium: fixing required dependency on mochi-margo versions * Add new recipe aotriton for rocm. (#49038) * add new reciple aotriton for rocm. used for py-torch * update the git info * fix style error * fix style error * fix style error * address review comments * fix style error * update maintainers (#48295) * acts dependencies: new versions as of 2025/02/17 (#49073) This commit adds detray v0.88.1, covfie v0.12.0 and v0.12.1, as well as ACTS v37.1.0. * magma: remove cuda_arch constraint on 2.9.0+ (#49019) * plsm: new package (#48875) * Adding plsm package * [@spackbot] updating style on behalf of PhilipFackler * Removing redundant text * Add description * Add blank line * Add cuda_arch and update int64 handling * gnutls: add v3.8.9 (#49062) * gnutls: add v3.8.9 * gnutls: address super small nitpick * gnutls: fix git url * qemacs: add v6.4.1, fix +doc (#48722) * py-fastjsonschema: add 2.17 to 2.21.1; note python dependencies (#47926) * py-fastjsonschema: add 2.17 to 2.21.1; note python dependencies * py-importlib-resources: add v5.13 to 6.4 * Revert "py-importlib-resources: add v5.13 to 6.4" This reverts commit 1df208874c799b99dcfc43f13ae85f9324c59b52. --------- Signed-off-by: Shane Nehring <snehring@iastate.edu> Signed-off-by: Jonathon Anderson <anderson.jonathonm@gmail.com> Signed-off-by: Todd Gamblin <tgamblin@llnl.gov> Signed-off-by: Mathieu Taillefumier <mathieu.taillefumier@free.fr> Signed-off-by: Teague Sterling <teaguesterling@gmail.com> Signed-off-by: Howard Pritchard <howardp@lanl.gov> Signed-off-by: Justin Cook <jscook@lbl.gov> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Etienne Ndamlabin <88906611+endamlabin@users.noreply.github.com> Co-authored-by: Etienne Ndamlabin <jean-etienne.ndamlabin-mboula@inria.fr> Co-authored-by: Sreenivasa Murthy Kolam <sreenivasamurthy.kolam@amd.com> Co-authored-by: Thomas Bouvier <contact@thomas-bouvier.io> Co-authored-by: Wouter Deconinck <wdconinc@gmail.com> Co-authored-by: G-Ragghianti <33492707+G-Ragghianti@users.noreply.github.com> Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com> Co-authored-by: David Schneller <12698011+davschneller@users.noreply.github.com> Co-authored-by: Juan Miguel Carceller <22276694+jmcarcell@users.noreply.github.com> Co-authored-by: jmcarcell <jmcarcell@users.noreply.github.com> Co-authored-by: snehring <7978778+snehring@users.noreply.github.com> Co-authored-by: Buldram <buldram@proton.me> Co-authored-by: jmuddnv <143751186+jmuddnv@users.noreply.github.com> Co-authored-by: Thomas-Ulrich <ulrich@geophysik.uni-muenchen.de> Co-authored-by: Satish Balay <balay@mcs.anl.gov> Co-authored-by: Massimiliano Culpo <massimiliano.culpo@gmail.com> Co-authored-by: Filippo Spiga <spiga.filippo@gmail.com> Co-authored-by: Harmen Stoppels <me@harmenstoppels.nl> Co-authored-by: Richard Berger <rberger@lanl.gov> Co-authored-by: Jonathon Anderson <17242663+blue42u@users.noreply.github.com> Co-authored-by: Harmen Stoppels <harmenstoppels@gmail.com> Co-authored-by: Tamara Dahlgren <35777542+tldahlgren@users.noreply.github.com> Co-authored-by: Eric Berquist <727571+berquist@users.noreply.github.com> Co-authored-by: wspear <wspear@cs.uoregon.edu> Co-authored-by: wspear <wspear@users.noreply.github.com> Co-authored-by: Alec Scott <hi@alecbcs.com> Co-authored-by: John W. Parent <45471568+johnwparent@users.noreply.github.com> Co-authored-by: Todd Gamblin <tgamblin@llnl.gov> Co-authored-by: Chris Marsh <chrismarsh.c2@gmail.com> Co-authored-by: Rocco Meli <r.meli@bluemail.ch> Co-authored-by: afzpatel <122491982+afzpatel@users.noreply.github.com> Co-authored-by: psakievich <psakiev@sandia.gov> Co-authored-by: Brian Spilner <Try2Code@users.noreply.github.com> Co-authored-by: Dominic Hofer <6570912+dominichofer@users.noreply.github.com> Co-authored-by: Greg Becker <becker33@llnl.gov> Co-authored-by: danielsjensen1 <dsjense@sandia.gov> Co-authored-by: Till Ehrengruber <till.ehrengruber@cscs.ch> Co-authored-by: Henri Menke <henri@henrimenke.de> Co-authored-by: pauleonix <paul.grosse-bley@ziti.uni-heidelberg.de> Co-authored-by: Mosè Giordano <765740+giordano@users.noreply.github.com> Co-authored-by: Zack Galbreath <zack.galbreath@kitware.com> Co-authored-by: Seth R. Johnson <johnsonsr@ornl.gov> Co-authored-by: Weiqun Zhang <WeiqunZhang@lbl.gov> Co-authored-by: Taillefumier Mathieu <29380261+mtaillefumier@users.noreply.github.com> Co-authored-by: Mathieu Taillefumier <mathieu.taillefumier@free.fr> Co-authored-by: Piotr Sacharuk <107190444+PiotrSacharuk@users.noreply.github.com> Co-authored-by: eugeneswalker <eugenesunsetwalker@gmail.com> Co-authored-by: psakievich <psakievich@users.noreply.github.com> Co-authored-by: rfbgo <109985755+rfbgo@users.noreply.github.com> Co-authored-by: Felix Thaler <thaler@cscs.ch> Co-authored-by: Bernhard Kaindl <bernhardkaindl7@gmail.com> Co-authored-by: japlews <22622327+japlews@users.noreply.github.com> Co-authored-by: George Young <A-N-Other@users.noreply.github.com> Co-authored-by: Stephen Nicholas Swatman <stephen@v25.nl> Co-authored-by: Davis Herring <herring@lanl.gov> Co-authored-by: Dom Heinzeller <dom.heinzeller@icloud.com> Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja> Co-authored-by: Izaak "Zaak" Beekman <contact@izaakbeekman.com> Co-authored-by: ddement <ddement@gatech.edu> Co-authored-by: LMS Bioinformatics <bioinformatics@lms.mrc.ac.uk> Co-authored-by: Matt Thompson <matthew.thompson@nasa.gov> Co-authored-by: SXS Bot <31972027+sxs-bot@users.noreply.github.com> Co-authored-by: sxs-bot <sxs-bot@users.noreply.github.com> Co-authored-by: AMD Toolchain Support <73240730+amd-toolchain-support@users.noreply.github.com> Co-authored-by: vijay kallesh <Vijay-teekinavar.Kallesh@amd.com> Co-authored-by: Alberto Sartori <alberto.sartori@huawei.com> Co-authored-by: Alberto Invernizzi <9337627+albestro@users.noreply.github.com> Co-authored-by: Thomas Madlener <thomas.madlener@desy.de> Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi> Co-authored-by: Vinícius <viniciusvgp@gmail.com> Co-authored-by: Teague Sterling <teaguesterling@users.noreply.github.com> Co-authored-by: Shane Nehring <snehring@iastate.edu> Co-authored-by: Sergey Kosukhin <sergey.kosukhin@mpimet.mpg.de> Co-authored-by: Robert Mijakovic <robert.mijakovic@gmail.com> Co-authored-by: Paul <bryantpj@ornl.gov> Co-authored-by: Paul R. C. Kent <kentpr@ornl.gov> Co-authored-by: Vanessasaurus <814322+vsoch@users.noreply.github.com> Co-authored-by: github-actions <github-actions@users.noreply.github.com> Co-authored-by: Howard Pritchard <howardp@lanl.gov> Co-authored-by: jgraciahlrs <gracia@hlrs.de> Co-authored-by: Fernando Ayats <ayatsfer@gmail.com> Co-authored-by: Tim Haines <thaines.astro@gmail.com> Co-authored-by: renjithravindrankannath <94420380+renjithravindrankannath@users.noreply.github.com> Co-authored-by: Peter Scheibel <scheibel1@llnl.gov> Co-authored-by: alalazo <alalazo@users.noreply.github.com> Co-authored-by: Tara Drwenski <tdrwenski@users.noreply.github.com> Co-authored-by: Justin Cook <jscook@lbl.gov> Co-authored-by: jean-francois-sa <jleblancrichard@simplyanalytics.com> Co-authored-by: etiennemlb <eti.malaboeuf@gmail.com> Co-authored-by: Richard Berger <richard.berger@outlook.com> Co-authored-by: Dmitri Smirnov <dmixsmi@gmail.com> Co-authored-by: John Biddiscombe <biddisco@cscs.ch> Co-authored-by: Dave Keeshan <96727608+davekeeshan@users.noreply.github.com> Co-authored-by: Rémi Lacroix <remi.lacroix@idris.fr> Co-authored-by: Vivek Kale <11766050+vlkale@users.noreply.github.com> Co-authored-by: vlkale <vlkale@users.noreply.github.com> Co-authored-by: Marc T. Henry de Frahan <marc.henrydefrahan@nrel.gov> Co-authored-by: Robert Maaskant <RobertMaaskant@users.noreply.github.com> Co-authored-by: Matthew Lesko <matthew.w.lesko@nasa.gov> Co-authored-by: Paul Gessinger <hello@paulgessinger.com> Co-authored-by: Vicente Bolea <vicente.bolea@kitware.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Pranav Sivaraman <pranavsivaraman@gmail.com> Co-authored-by: Filippo Barbari <filippo.barbari@gmail.com> Co-authored-by: Matthieu Dorier <mdorier@anl.gov> Co-authored-by: Nai-Yuan Chiang <sorakid507@gmail.com> Co-authored-by: Cameron Rutherford <rcamruzz@amazon.com> Co-authored-by: Philip Fackler <49726797+PhilipFackler@users.noreply.github.com> Co-authored-by: dmagdavector <david.magda@vectorinstitute.ai>

…#48164) * damaris: add v1.12.0, update maintainers (#48674) Co-authored-by: Etienne Ndamlabin <jean-etienne.ndamlabin-mboula@inria.fr> * Bump up the version for rocm-6.3.1 release (#48440) This PR updates the versions for the rocm recipes for rocm-6.3.1 release. * py-flash-attn: add missing triton dependency (#48645) * hep stack: additional event generator packages (#48565) * hep stack: additional event generator packages * hep: adidtional packages * hep: collier doesn't have +pic +shared * py-awkward-cpp: fix scikit-build-core range of applicability * hep: disable agile * hep: disable garfieldpp and genie * py-wxpython: depends_on pkgconfig even if using external wxwidgets * hep: disable professor * papi: fix error finding gmake during post-install testing (#48592) * JAX: add v0.4.32+ (#46346) * JAX: add v0.4.34 * Disable search for clang * Update CUDA flags * Add py-jax 0.4.33, comment out until py-jaxlib 0.4.33 is also released * Fix GCC build * Try TF_NVCC_CLANG * py-jax: add v0.4.34 * jax no longer has separate tags for jaxlib * Install compiled wheel * Join path before glob * Wheel is in spack stage, not tmp path * Add 0.4.35 * Add newer versions * Build system has been refactored yet again * Drop clang * Fix build with source tarball, rocm support * Support GCC * Remove clang-specific compiler flags * enable_cuda flag was removed * Fix logic * py-jax: add v0.4.38 * Add patch to fix GCC support * Patch no longer needed * Skip patching, directly pass flags * New flags * Remove unused import * Patch changed * Use older version of patch * Newer patch * Add CUDA symlink * Symlink more directories * Recursive symlink * Import function * Recursive search * Undo cuda changes * Add v0.5.0 * I quit * py-geemap: add new package (#48602) * easi: add v1.5.1; relax yaml-cpp and lua requirements (#48675) * thepeg: extend the rivet@:3 dependency up to version 2.3 (#48691) Co-authored-by: jmcarcell <jmcarcell@users.noreply.github.com> * py-ipyrad: adding version 0.9.102 (#48686) Signed-off-by: Shane Nehring <snehring@iastate.edu> * autodock-vina: adding version 1.2.6 (#48684) Signed-off-by: Shane Nehring <snehring@iastate.edu> * toybox: add v0.8.12 (#48657) * Changes for NVIDIA HPC SDK 25.1 (#48696) * update hypre version and add new memalign for petsc (#47831) * petsc+rocm: add dependency on hipblas-common (#48644) * spec.py: fix ArchSpec.intersects (#48741) fixes a bug where `x86_64:` and `ppc64le:` intersected, and x86_64: and :haswell did not. * ucx: adding 1.18.0 (#48742) * Adding UCX 1.18.0 * Verified and correct hash. * MAGMA: add v2.9.0 (#48750) * Deprecate frontend/backend os/target (#47756) * package api: drop wildcard re-export (#48760) * package api: drop wildcard re-export To ensure package repos are forward/backward compatibility with Spack, we should explicitly export all symbols we want to expose in the public package API, and drop `from spack.something import *` because removal/addition to the public API will go unnoticed. Also `llnl.util.filesystem` has some methods that shouldn't be exposed in the package API, so better to enumerate a subset explicitly. * remove flatten_dependencies / install_dependency_symlinks * py-cmake: remove. remove deprecated cmake versions (#48763) * Remove pipelines and images based on ppc64le (#48767) * petsc: only conflict with kokkos@4.5: if it is enabled (#48698) * hpctoolkit: Add `+docs` variant and manpages (#48566) * py-mdit-py-plugins: Add new versions 0.3.5, 0.4.2 Signed-off-by: Jonathon Anderson <anderson.jonathonm@gmail.com> * py-myst-parser: Add new versions 0.19.0 to 4.0.0 Signed-off-by: Jonathon Anderson <anderson.jonathonm@gmail.com> * hpctoolkit: Add +docs variant and manpages This commit unconditionally enables manpages for the HPCToolkit tools. The new `+docs` variant enables additional documentation, specifically the user's manual. Both require new build-time dependencies. Signed-off-by: Jonathon Anderson <anderson.jonathonm@gmail.com> --------- Signed-off-by: Jonathon Anderson <anderson.jonathonm@gmail.com> * fmt: simplify +pic (#48766) Co-authored-by: Harmen Stoppels <harmenstoppels@gmail.com> * Docs/bugfix: correct return for Adding flags to configure (#48434) * binutils: conflict on configuration with build issues (#42949) * Create SALT package.py (#48758) * Create SALT package.py Added a package for the SALT Source AnaLysis Toolkit @zbeekman * [@spackbot] updating style on behalf of wspear * Update package.py Line wrap --------- Co-authored-by: wspear <wspear@users.noreply.github.com> * smee-client: add v2.0.4 (#48384) * CMake: add v3.31.5, v3.30.7 (#48759) * builtin: remove redundant imports (#48765) * builtin: remove redundant llnl.util.filesystem import * remove redundant import spack.version * unsorted fixes * more spack.version * abinit: pass flag correctly (#48788) * Add py-zarr 3, which includes a new required package py-donfig, and a bug fix to the patch range with numcodecs (#48786) * libxc: add CMake builder (#48772) * libsmeagol * libxc cmake * cmake support * revert changes * make spackbot happy * fix * Update package.py * hipblaslt: update cmake dependency (#48637) * hipblaslt: update cmake dependency 1 error found in build log: >> 3 CMake Error at CMakeLists.txt:24 (cmake_minimum_required): 4 CMake 3.25.2 or higher is required. You are running version 3.22.1 5 6 7 -- Configuring incomplete, errors occurred! See build log for details: /scratch/svcpetsc/spack-rocm/spack-stage/spack-stage-hipblaslt-6.3.0-pabb7t4rheqkz74lfzbsnqi6vnpiqwlq/spack-build-out.txt * Update var/spack/repos/builtin/packages/hipblaslt/package.py Co-authored-by: afzpatel <122491982+afzpatel@users.noreply.github.com> --------- Co-authored-by: afzpatel <122491982+afzpatel@users.noreply.github.com> * Move from python2 compliant IOError and EnvironmentError to python3-only OSError (#48764) * IOError -> OSError * also do EnvironmentError * py-sphinx: mark Python compatibility (#48796) * spack.package: wrap llnl.util.tty (#48793) avoid import of llnl.util.tty in packages * spack.package: re-export EnvironmentModifications / Prefix (#48792) * Remove unused values (#48795) Signed-off-by: Todd Gamblin <tgamblin@llnl.gov> Co-authored-by: Todd Gamblin <tgamblin@llnl.gov> * petsc, py-petsc4py: add v3.22.3 (#48785) * libsmeagol (#48776) * libsmeagol * add support for intel and add conflicts * cp2k * Bug Fix: Better incremental check for CMake (#48775) * Bug Fix: Better incremental check for CMake * Fix syntax error * Ensure match of config artifact with generator * add cdo@2.5.0 (#48801) * Added salt variant to tau (#48782) * Added salt variant to tau * Update package.py * [@spackbot] updating style on behalf of wspear --------- Co-authored-by: wspear <wspear@users.noreply.github.com> * Remove patch on main (#48798) Patch got merged: https://github.com/natefoo/slurm-drmaa/pull/62 * kokkos-nvcc-wrapper: add version 4.5.00 and 4.5.01 (#48802) * env create: create copies of relative include files in envs created from manifest (#48689) Currently, environments created from manifest files with relative includes result in broken references to config files. This PR modifies `spack env create` to create local copies in the new environment of any local config files from relative paths in the environment manifest passed as an init file. This PR does not change the behavior if the include is an absolute path or if the include is from a relative path outside the environment directory, but it does warn about missing relative includes if they are inside the environment directory. Includes regression test and short blurb in docs. * py-sphinx-rtd-theme: add v2.0.0, v3.0.0 (#48756) * Add versions 2 and 3 of py-sphinx-rtd-theme. Allow for versions of py-sphinx greater than 6. Fix the Python version for older versions that depend on distutils. Get the py-docutils dependency from the py-sphinx recipe. * Depend purely on the py-docutils dependency in py-sphinx. * More refined dependency versioning. * Fixed versioning for py-sphinx and py-docutils. * CP2K: add 2025.1 version and DFTD4 support (#48489) * cp2k: add dftd4 variant * better conflict and make support * typo * Update var/spack/repos/builtin/packages/cp2k/package.py * Update var/spack/repos/builtin/packages/cp2k/package.py * oci/opener.py: respect system proxy settings (#48783) * vtk-m: CMAKE_CXX_COMPILER is not a BOOL (#48813) * gcc: remove --with-ld=ld-classic (#48826) * nanotron: add new package (#48582) * nanotron: add new package Also, update some dependencies and add missing ones. * Add variant +examples needed to execute example scripts * fix: add missing branch attribute * Remove master version * fix: use Github hash * embree: fix tests by building tutorial's embree_viewer for tests (#48392) * import-check: improve how problematic imports are displayed (#48825) The import-check action now presents problematic import statements introduced by the PR better. The idea is roughly: * Let (V₁, E₁) be the graph of modules as vertices and import statements as edges before the change * Let (V₂, E₂) be the graph after the code change, which is typically a small perturbation of (V₁, E₁). * X₁ = FAS(V₁, E₁) is the feedback arc set before (a minimal set of edges to delete to make it acyclic) * X₂ = FAS(V₂, E₂ ∖ X₁) is the feedback arc set after deletion of the minimal set of edges that made the old graph acyclic. * X₃ = FAS(V₂, E₂) is the feedback arc set after Previously I displayed X₁ and X₃ and users had to diff themselves. Now, I'm showing X₂, which is a small set, typically directly related to code changes. However, it can be that a small code change adding say 2 problematic imports creates a completely different solution X₃ that only requires deletion of just 1 different import. In that case the user is informed that they can potentially do less work. So for PR #48784 the output is now: > The overall number of problematic import statements increased by 1 from 31 to 32. > This is likely a direct consequence of the following import statements: > > ``` > spack/config imports: spack.spec, spack.util.path, spack.util.remote_file_cache > ``` > > However, instead of removing 3 import statements, it is sufficient to remove only 1 > import statement from the following list: > > ``` > spack/concretize imports: spack.bootstrap, spack.solver.asp > spack/environment imports: spack.bootstrap, spack.environment > spack/fetch_strategy imports: spack.version.git_ref_lookup > spack/install_test imports: spack.build_environment, spack.package_base > spack/modules imports: spack.modules > spack/platforms imports: spack.config > spack/relocate imports: spack.bootstrap > spack/repo imports: spack.package_base, spack.patch, spack.tag > spack/spec imports: spack.binary_distribution, spack.compiler, spack.compilers, spack.concretize, spack.environment, spack.hash_types, spack.provider_index, spack.repo, spack.spec_parser, spack.store, spack.traverse, spack.variant, spack.version.git_ref_lookup > spack/subprocess_context imports: spack.environment > spack/util/gpg imports: spack.bootstrap > spack/util/package_hash imports: spack.package_base > spack/util/path imports: spack.config, spack.environment > spack/util/remote_file_cache imports: spack.util.web > ``` from which the user can figure out that `spack/util/remote_file_cache imports: spack.util.web` is the "bottleneck" now. * spack_yaml: use unambiguous variable name (#48832) * style: fix `not in` and `is not` (#48831) These are some changes that `ruff check --fix` would make that the current `spack style` also agrees with. Make the changes now so that the `ruff` change is less disruptive. Signed-off-by: Todd Gamblin <tgamblin@llnl.gov> * Set version to v1.0.0.dev0 (#48791) * import-check: enable color output (#48842) * berkeleygw: add -o flag to tar extraction (#48816) when extracting as root user, avoid that tar attempts to change file ownership * llvm: deprecate old patch releases (#48762) * cuda: add v12.8 (#48708) * sirius: patch pugixml (#48841) * ziatest: add new package (#48809) * gitlab: remove isc stacks (#48811) * gcc: deprecate old patch releases (#48761) * CP2K: use libxc@7 for master/next release (#48808) * packge_base.py: remove _patches_by_hash (#48768) * cdash: avoid build_opener (#48846) * g4vg: new package (#48844) * g4vg: new package * [@spackbot] updating style on behalf of sethrj * r-dmrcate: add v2.16.0, v3.0.0, v3.2.0 (#48158) * r-dmrcate: add new versions * r-dmrcate: require `r@4.3.0` for v2.99.0+ * r-dmrcate: update dependencies * py-tensorflow: add 2.18.0-rocm-enhanced (#48711) * py-tensorflow: add 2.18.0-rocm-enhanced * fix style * fix style * fix style * review changes * review changes * remove hipblaslt dependency * remove ci changes and force ROCm 6.3.1 for newest TF * remove rocm 6.3.1 dependency * simplify configure fix * rocm-examples and rocjpeg: new packages (#47695) * new package: rocm-examples * add new package rocjpeg and update rocm-examples for 6.3.0 * fix licenses * add versions 6.3.1 * change homepage and git * add f-string * Tesseract v5.5.0 (#48866) * leptonica: adding v1.85.0 Signed-off-by: Shane Nehring <snehring@iastate.edu> * tesseract: adding v5.5.0 Signed-off-by: Shane Nehring <snehring@iastate.edu> --------- Signed-off-by: Shane Nehring <snehring@iastate.edu> * py-geojson: Add new package (#48847) * Add new package py-geojson * fix when * isa-l: add v2.31.1 (#48859) * Add new package func (#48849) * icu4c: add v75.1, v76.1 (#48858) * Add new package py-metis (#48848) * cppgsl: add v4.1.0 (#48864) * libdrm: add v2.4.124 (#48860) * amrex: add v25.02 (#48853) * sherpa: support cxxstd=20 when=@3: (#48829) * sherpa: support cxxstd=20 when=@3: * hep: sherpa cxxstd=20 * netlib-scalapack: Update version (#48667) * Update scalapack version Signed-off-by: Mathieu Taillefumier <mathieu.taillefumier@free.fr> * use url_for_version Signed-off-by: Mathieu Taillefumier <mathieu.taillefumier@free.fr> * use spec.satisfies instead of version() --------- Signed-off-by: Mathieu Taillefumier <mathieu.taillefumier@free.fr> Co-authored-by: Mathieu Taillefumier <mathieu.taillefumier@free.fr> * fcgi: add v2.4.3, v2.4.4 (#48856) * update pyproject.toml for `ruff format` (#48823) Add ruff configuration to `pyproject.toml`. This allows `ruff format` in the Spack repository to format all the files we care about, with our line length of 99, the exceptions we already put in place, and excluding things we don't auto-format, like vendored dependencies. Right now it'll reformat 175 or so files, but only slightly, in places where `ruff` differs from `black`. For the most part I like the ruff format decisions better than `black`, but none of the changes seem too severe. This does not change `spack style` -- I figure that can come later but this at least will let people start playing with `ruff`. --------- Signed-off-by: Todd Gamblin <tgamblin@llnl.gov> * dd4hep: add v1.31 (#48850) * libsm: add v1.2.5 (#48862) * Apply workaround for oneAPI compiler for upcxx problem with a template argument list (#48843) * Fix upcxx problem with a template argument list is expected after a name prefixed by the template keyword * Revert "Fix upcxx problem with a template argument list is expected after a name prefixed by the template keyword" This reverts commit faf9b8ce850dbb4c38a5019a7071415e3c6dc086. * Apply workaround for oneAPI compiler * style problem resolved * use spec.satisfies syntax --------- Co-authored-by: eugeneswalker <eugenesunsetwalker@gmail.com> * Remove ISC stacks environment files (#48851) Follow-up to #48811 * Remove variable from cmake.py (#48824) * Remove variable from cmake.py #48775 left a dangling variable that was not caught in CI but by the eyes of @haampie. Restructure variable to local method. * [@spackbot] updating style on behalf of psakievich * Update cmake.py * Update lib/spack/spack/build_systems/cmake.py * Update lib/spack/spack/build_systems/cmake.py --------- Co-authored-by: psakievich <psakievich@users.noreply.github.com> * sirius: add v7.6.2 (#48797) Co-authored-by: Mathieu Taillefumier <mathieu.taillefumier@free.fr> Co-authored-by: Rocco Meli <r.meli@bluemail.ch> * gha: standalone import-check (#48873) * ci: add codecov token secret to coverage upload job (#48880) Codecov needs to see the token secret when uploading, so we have to add this line to the workflow YAML: ```yaml with: token: ${{ secrets.CODECOV_TOKEN }} ``` Signed-off-by: Todd Gamblin <tgamblin@llnl.gov> * ci: bump import-check (#48883) * pfind: new package (#48685) * py-elevation: new package (#48836) * spec.py: fix hash change due to None vs {} (#48854) * Fix hash change due to None vs {} * Enforce null for empty list of external_modules * nnn: new package (#46174) Co-authored-by: Bernhard Kaindl <bernhardkaindl7@gmail.com> * Fix esmf usage, add new version (#48835) * bash: add autotools dependencies (#48874) * Scotch: add v7.0.6, add testing option (#48781) * code-server: update to v4.96.4 (#48828) * acts: add v39.0.0 (#48839) This commit adds version 39.0.0 of the ACTS package which, as far as I can tell, doesn't require any dependency updates. * spec.py: ensure spec.extra_attributes is {} if is null in json (#48896) * harfbuzz: add v10.2.0 (#48857) * libice: add v1.1.2 (#48861) * relocate.py: don't warn about symlinks (#48904) `relocate_links` warns when the target is absolute and not matched by any prefix from the prefix to prefix map. This can lead to false positives, cause the prefix to prefix map does not contain trivial/identity entries whenever a package is installed to its original location. Since relocate_links is the odd one out there (we don't warn about similar issues with rpaths, etc), just remove the warning. * hip-tests: new package (#47273) * hip-tests: add new package * remove hip-tests from hip recipe * remove old versions * fix style * add missing import * bump hip-tests to 6.3.1 * fix style * flecsi: new version 2.3.1 (#48867) * flecsi: add new version 2.3.1, remove develop * flecsi: remove kokkos and openmp variants moving forward * flecsi: propagate cuda and rocm settings from kokkos * Update var/spack/repos/builtin/packages/flecsi/package.py Co-authored-by: Davis Herring <herring@lanl.gov> * flecsi: remove redundant depends_on lines * flecsi: correct legion dependency * flecsi: deprecate v2.0.0 and v2.1.0 * flecsi: force +openmp if ^kokkos+openmp --------- Co-authored-by: Davis Herring <herring@lanl.gov> * Update py-arch, py-statsmodels (add 0.14.1), py-patsy (add 0.5.4) to be able to use py-cython@3 (#48769) * Add py-patsy@0.5.4 * Correct py-numpy dependency in py-arch * Add py-statsmodels@0.14.1 and update dependencies * Add climbfuji as maintainer for py-patsy * Add climbfuji as maintainer for py-statsmodels * Update var/spack/repos/builtin/packages/py-statsmodels/package.py * enzyme: add v0.0.172 (#48881) * spec.py: ensure == is false if true modulo precomputed dag hash (#48889) * llvm: fix @15 %apple-clang@16 (#48887) * spiner: add v1.6.3 (#48871) * spiner: update package logic * singularity-eos: remove spiner cuda_arch propagation * spiner: add version 1.6.3 * sherpa: +hepmc3root only when +root (#48827) * sherpa: +hepmc3root only when +root * sherpa: fix style * salt: add v0.3.0 (#48877) * salt: Add v0.3.0 of SALT This version contains important bug fixes for building and parsing projects containing Fortran * salt: Be more explicit about dependency types - llvm+clang+flang is needed at build, link and runtime for the correct operation of SALT - Testing with llvm@master ( llvm > 19.x ) shows that SALT is currently incompatible with the latest llvm API so an updated salt will be required when LLVM 20 is released * openturbine: add new package (#48683) * PyTorch: add v2.6.0 (#48794) * mummer4: patching to allow building with %gcc@13: (#38292) Co-authored-by: LMS Bioinformatics <bioinformatics@lms.mrc.ac.uk> Co-authored-by: Massimiliano Culpo <massimiliano.culpo@gmail.com> * fms: add 2025.01, 2024.03 (#48812) * py-shapely: add v2.0.7 (#48810) * spectre: add v2025.01.30 (#48803) Co-authored-by: sxs-bot <sxs-bot@users.noreply.github.com> * py-numba: Add version 0.61 (#48837) * amdfftw: fix broken build, adjust flags for performance tuning (#48754) With CFLAGS, the code path in the amdfftw build system will bypass the logic around AMD_ARCH. --------- Co-authored-by: vijay kallesh <Vijay-teekinavar.Kallesh@amd.com> * justbuild: add v1.4.3 (#48898) * nvpl-blas, nvpl-lapack: add v0.4.0.1, v0.3.0 (#48901) * hep stack: build also with cuda and rocm where possible (#48528) * lcio: add v2.22.4 (#48895) * Add a message for CMake incremental build (#48905) * Add a message for CMake incremental build Requested message to explain CMake phase is getting skipped. * [@spackbot] updating style on behalf of psakievich * Update import --------- Co-authored-by: psakievich <psakievich@users.noreply.github.com> * dcap: depends_on libxcrypt (#48903) * Add new version of r-curl (#48912) * pika: Add 0.32.0 (#48897) * icu4c: no cxxstd flag option on Windows (#48510) * ICU4C: Don't reference a spec variant on a platform on which it's not defined * icu4c: no cxx flag on Windows * dla-future-fortran: add v0.3.0 (#48900) * simgrid: add v3.36 (#48909) * dyninst: cleanup package (#47637) * Use more idiomatic construct, shorten recipe * Remove deprecated versions, and associated patches * Remove v10.0.0 * Windows: Update default config for stage location (#48511) Current location is within the Spack prefix, which causes builds to pollute VCS with stage artifacts and generally inflates the Spack install prefix. This PR moves it to the user cache location now that we can consistently support paths with spaces on Windows. * py-maturin: add v1.8.2 and refined dependencies (#48915) * clingo-bootstrap: fix +optimized build (#48931) * fix regression `apple-clang` vs `%apple-clang` * use f-strings * remove --verbose flag from LDFLAGS * Fix regression due to dyninst update (#48935) * trexio: fix issues with autotools build system (#48923) * package_base.py: remove use_cray_compiler_names (#48932) * Apply workarounds for oneAPI compiler for ascent problem with build (#48918) * Apply workarounds for oneAPI compiler for ascent problem with build * Use the way with use patch through the PR address * stylecheck - missing comma * libgcrypt: fix enforced -O0 (#48940) Signed-off-by: Shane Nehring <snehring@iastate.edu> Co-authored-by: Shane Nehring <snehring@iastate.edu> * serialbox: add version 2.6.2 (#48937) * nwchem: add master (#48919) * Add possibility to build nwchem from master branch * add oneapi@2025: patch for @7.2.3 --------- Co-authored-by: eugeneswalker <eugenesunsetwalker@gmail.com> * Python: add new versions (#48950) * Python: add new versions * black * reframe: add v4.6.4 -> v4.7.2 (#48242) * go: add v1.23.6 (#48955) * qmcpack: add v4.0.0 (#48921) * py-einops: add v0.8.1 (#48954) * flux-sched: add v0.42.1 (#48952) Co-authored-by: github-actions <github-actions@users.noreply.github.com> * Quantum ESPRESSO: add v7.4.1 (#48949) * duckdb: add v1.2.0 (#48902) Signed-off-by: Teague Sterling <teaguesterling@gmail.com> * mapl: add v2.53.1, v2.54.1 (#48944) * log.py: remove setenv calls (#48933) * nim: add v2.2.2 (#48929) * Update GFE packages (#48899) * OpenMPI: add version 4.1.8 (#48922) Signed-off-by: Howard Pritchard <howardp@lanl.gov> * extrae: tighten dependencies on boost for +dyninst (#48938) * py-iterative-stats: add 0.1.1 (#48959) * import-check: bump (#48968) * ports-of-call: add v1.6.0, v1.7.0, v1.7.1 (#48870) * acts dependencies: new versions as of 2025/02/10 (#48969) This commit adds detray v0.88.0 and GeoModel v6.9.0. * cbtf-krell: Update Boost dependency (#47133) * Update Boost * Add gotcha * Add patch for build errors * Allow building with latest Dyninst * Fix patch url * lua-sol2: Apply workaround for oneAPI compiler for problem with build (#48920) * Bump up the version for rocm-6.3.2 release (#48787) * Bump up the version for rocm-6.3.2 release * rocm-openmp-extras update and style correction * Updating mivisionx, omniperf, rccl & rocprofiler-systems * Updating hipsparselt & rocm-opencl * rocprofiler-systems on gcc-13 and rvs commit instead of patch * Updated rocjpeg & rocm-examples for 6.3.2 * ROCPROFSYS_BUILD_DYNINST & DYNINST_BUILD_TBB are required only with gcc-13 --------- Co-authored-by: afzpatel <122491982+afzpatel@users.noreply.github.com> * spack compiler find: detect `flang-new` and `flang` in newer LLVM versions (#48914) * rivet: patch missing header in 3.1.10 (#48977) * concretizer: reduce search space with static analysis (#48729) Currently, when we setup the ASP problem for `clingo`, we don't take into account the configuration. This results in setting up ASP problems that are larger than necessary, with possibly redundant information, and higher concretization times. This PR tries to improve things by adding an opt-in feature that computes the _possible dependencies_ of a solve taking also into account the current configuration, and avoids adding possible dependencies that we are certain can't be in the final solution. The feature can be activated with: ```yaml concretizer: static_analysis: true ``` Examples of simple rules to discard dependencies are: - Dependencies that are not buildable, and for which no binary is present (e.g. `cray-mpich` etc. on non Cray systems) - Dependencies that are not for the current platform (e.g. `msmpi` on non Windows platforms) - Conditional dependencies that cannot be activated, because of some user requirement (e.g. `cuda` etc. if the user requires `~cuda` in configuration) - Virtual providers that cannot be used, because of a requirement on a virtual The speed-up these rules seem to give depends on the use case at hand, but if the configuration is updated properly, they are noticeable. Since in cases where there is no rule to exclude packages upfront, reuse is active, and this option is activated, it's possible to see some minor slow down, the feature has been added as opt-in, so it's turned off by default. * spack.util.elf: catch seek errors (#48972) * hep: rivet: require hepmc=3 (#48976) * Fix performance issue on macOS (#48997) archspec.cpu.host() is not memoized, so compute it as less as possible. --------- Co-authored-by: alalazo <alalazo@users.noreply.github.com> * style.py: fix false negative in redundant import statements (#48980) * PyTorch: build flash attention by default, except in CI (#48521) * PyTorch: build flash attention by default, except in CI * Variant is boolean, only available when +cuda/+rocm * desc -> _desc * kokkos et al. : don't monkeypatch spec in callbacks (#48916) Currently, a few packages using kokkos rely on kokkos itself monkeypatching its own spec to provide some attribute. In this commit we change this attribute to be defined on the package, and never be monkeypatched. * gmake: add empty libs property, remove link deptypes from dependents (#48995) * package_hash.py: move metadata_attrs inline out of package_base (#48981) * gmake: fix def libs/headers (#49009) * Spec.package_class -> spack.repo.PATH.get_pkg_class (#48985) * libfabric: use the class variable to get the list of fabrics (#49007) Suggested by: alalazo <alalazo@users.noreply.github.com> Signed-off-by: Justin Cook <jscook@lbl.gov> * py-transformers: add new versions (#49000) * py-transformers: add new versions * py-tokenizers: add new versions * Apply suggestions from code review * lcio: Add latest 2.22.5 tag (#48991) * concretize.lp: don't warn about deprecation when external (#49008) * Spec.is_virtual -> spack.repo.PATH.is_virtual (#48986) * g4vg: add 'develop' branch (#49003) * g4vg: add develop version * celeritas: add develop version * Fix style * REVERTME: move celeritas changes to another branch * Get full repo * remove unneeded variable * Remove spack.repo.PATH.is_virtual call from SpecBuildInterface.(#48984) This PR is effectively a breaking change extracted from #45189, which removes support for spec["mpi"] if spec itself is openmpi / mpich that could provide mpi; from the Spec instance we don't have any parent it provides it to, hence it's a KeyError. * Spec.validate_detection -> spack.detection.path.validate_detection (#48987) * hep: add missing language dependencies (#48963) * highfive: add dependency on C https://gitlab.spack.io/spack/spack/-/jobs/14989283 * lhapdf: add dependency on C https://gitlab.spack.io/spack/spack/-/jobs/14989283 * vc: add dependency on C https://gitlab.spack.io/spack/spack/-/jobs/14989140 * davix: add dependency on C, C++ https://gitlab.spack.io/spack/spack/-/jobs/14989131 * pandorasdk: add dependency on C https://gitlab.spack.io/spack/spack/-/jobs/14989130 * veccore: add dependency on C https://gitlab.spack.io/spack/spack/-/jobs/14989118 * pythia6: add dependency on C https://gitlab.spack.io/spack/spack/-/jobs/14989116 * jwt-cpp: add dependency on C https://gitlab.spack.io/spack/spack/-/jobs/14989115 * collier: add dependency on C https://gitlab.spack.io/spack/spack/-/jobs/14989115 * hepmc: add dependency on C https://gitlab.spack.io/spack/spack/-/jobs/14989112 * clhep: add dependency on C https://gitlab.spack.io/spack/spack/-/jobs/14989075 * fastjet: add dependency on C https://gitlab.spack.io/spack/spack/-/jobs/14981340 * gosam-contrib: add dependency on C https://gitlab.spack.io/spack/spack/-/jobs/14978873 * thepeg: add dependency on C https://gitlab.spack.io/spack/spack/-/jobs/14997553 * cepgen: add dependency on C https://gitlab.spack.io/spack/spack/-/jobs/14997552 * podio: add dependency on C https://gitlab.spack.io/spack/spack/-/jobs/14997552 * pandoramonitoring: add dependency on C https://gitlab.spack.io/spack/spack/-/jobs/14997552 * lcio: add dependency on C https://gitlab.spack.io/spack/spack/-/jobs/14997513 * geant4: add dependency on C https://gitlab.spack.io/spack/spack/-/jobs/14997202 * evtgen: add dependency on C https://gitlab.spack.io/spack/spack/-/jobs/14996817 * apfel: add dependency on C https://gitlab.spack.io/spack/spack/-/jobs/14996779 * collier: add dependency on C, C++ https://gitlab.spack.io/spack/spack/-/jobs/14996770 * vecgeom: add dependency on C https://gitlab.spack.io/spack/spack/-/jobs/15003840 * dd4hep: add dependency on C https://gitlab.spack.io/spack/spack/-/jobs/15003839 * opendatadetector: add dependency on C https://gitlab.spack.io/spack/spack/-/jobs/15007666 * acts: add dependency on C https://gitlab.spack.io/spack/spack/-/jobs/15007827 * hepmc: remove dependency on fortran Co-authored-by: Seth R. Johnson <johnsonsr@ornl.gov> * thepeg: remove fortran dep Co-authored-by: Wouter Deconinck <wdconinc@gmail.com> * acts: add a conditional build dependency Co-authored-by: Wouter Deconinck <wdconinc@gmail.com> * opendatadetector: add comment to explain C dep Co-authored-by: Wouter Deconinck <wdconinc@gmail.com> --------- Co-authored-by: Seth R. Johnson <johnsonsr@ornl.gov> Co-authored-by: Wouter Deconinck <wdconinc@gmail.com> * apptainer: get_full_repo for branch main (#49002) * unifyfs: Apply workaround for oneAPI compiler for problem with build (#48962) * solver: add type-hints to OutputConfiguration (#48979) * Ci: ensure file path comparsion uses posix paths (#47033) Git always produces posix paths, ensure we're always comparsing apples to apples by normalizing paths compared to git output to posix. * postgresql: add v17.2 (#47811) * postgresql: add version 17.2 * postgresql: install flex, bison and perl when building versions 17 and up * postgresql: do not install perl by default when building versions 17 and up * cray-mpich: adding partial GTL support (#45830) cray-mpich now has a rocm variant. You can use gtl_lib in the flag_handler like so: ```python def flag_handler(self, name, flags): wrapper_flags = [] environment_flags = [] build_system_flags = [] if self.spec.satisfies("+rocm"): if self.spec.satisfies("^cray-mpich"): gtl_lib = self.spec["cray-mpich"].package.gtl_lib build_system_flags.extend(gtl_lib.get(name) or []) # hipcc is not wrapped, we need to pass the flags via the # build system. build_system_flags.extend(flags) return (wrapper_flags, environment_flags, build_system_flags) ``` --------- Co-authored-by: Richard Berger <rberger@lanl.gov> Co-authored-by: Massimiliano Culpo <massimiliano.culpo@gmail.com> Co-authored-by: Richard Berger <richard.berger@outlook.com> * lammps: use the Cray GTL (#46090) * lammps: add 20241119 and 20250204 releases (#48978) * plog: add new package (#48975) * binutils: add debuginfod variant + update deps (#49011) * h5hut: Remove H5_USE_110_API for newer versions (#48885) * h5hut: Remove H5_USE_110_API for newer versions * h5hut: style reformat and add maintainer * h5hut: correct version syntax for <v2.x.x * h5hut: Bump default version to 2.0.0rc7 and remove older rc candidates * Update var/spack/repos/builtin/packages/h5hut/package.py Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi> --------- Co-authored-by: Alberto Invernizzi <9337627+albestro@users.noreply.github.com> Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi> * spack debug create-db-tarball: remove after test failures (#49025) * bubblewrap: add versions up to v0.11.0 (#49023) * gftl: add v1.15.2 (#48992) * py-torchgeo: pyvista dep has been removed (#48990) * py-memray: add v1.15.0 (#48989) * yosys: add v0.50 (#48983) * laszip: Add version 3.4.4. (#48982) * py-numpy: add v2.2.3 (#49029) * pandora{pfa,sdk,monitoring}: add new versions and allow setting the C++ standard (#48300) * pandoramonitoring: add v3.6.0; pandorapfa: add v4.11.2 Remove variables that are not being used in pandorasdk. Use the C++ standard from ROOT when possible and pass -Wno-error to override the -Werror that will typically fail with a new standard. Add a cxxstd variant for pandorasdk * Fix style * Update var/spack/repos/builtin/packages/pandorasdk/package.py Co-authored-by: Wouter Deconinck <wdconinc@gmail.com> * Fix style --------- Co-authored-by: jmcarcell <jmcarcell@users.noreply.github.com> Co-authored-by: Wouter Deconinck <wdconinc@gmail.com> * easi@1.5.2 (#49013) * Put in maintainers for Kokkos Tools Spack package (#49018) * Kokkos Tools package.py: fix maintainers * Kokkos Tools package.py: remove white space between first and second maintainer in comma-separated list * [@spackbot] updating style on behalf of vlkale * Correct maintainers syntax Co-authored-by: Richard Berger <richard.berger@outlook.com> --------- Co-authored-by: vlkale <vlkale@users.noreply.github.com> Co-authored-by: Tamara Dahlgren <35777542+tldahlgren@users.noreply.github.com> Co-authored-by: Richard Berger <richard.berger@outlook.com> * zlib package: Ensure correct lib search on Windows (#48512) * Name of zlib's library differs on Windows; also account for name differing when building +shared * `zlib`'s `.libs` implementation was searching for the runtime libraries (the .dlls) and should be searching for link-time libs * Update openfast, amr-wind, and nalu-wind packages (#48994) * acts: conflicts ^geant4@11.3: when @:35 (#49028) * yq: add versions 4.44.5 and 4.44.6 and 4.45.1 (#49027) * openblas: .libs() uses self.libraries attribute (#48942) Currently this is hardcoded to the same value as listed in the class definition. If one ever overrides this attribute, such as: ``` packages: openblas: package_attributes: libraries = [ 'libopenblaso64', ] ``` this patch will make sure that override also in the `spec['openblas'].libs()` call. (Which happens in `hypre`, likely others). ( see https://spack.readthedocs.io/en/latest/packages_yaml.html#assigning-package-attributes ) Thanks to becker33 for debugging help in Slack * RepoSplit/tests: update repo tests relying on builtin package repo to only use mock repos (#48926) * RepoSplit/tests: update repo tests relying on builtin * test_repo_last_mtime: skip on windows due to mtime issues in CI * MesonPackage: depends_on pkgconfig (#46955) meson's `dependency` function often uses pkg-config to locate a dependency, and may even fall back to cmake. The former case is very common, and since packagers often forget to add the tiny pkgconfig package as a build dep, we do it for them. * Spec.__getitem__: restrict to direct deps + transitive runtime deps (#49016) With this change spec["pkg"] searches only direct dependencies and transitive link/run dependencies, ordered by depth. This avoids situations where we pick up unwanted deps of build/test deps. To reach those, you need to do spec["build_dep"]["pkg"] explicitly. Co-authored-by: Massimiliano Culpo <massimiliano.culpo@gmail.com> * views: normalize paths on case insensitive file systems (#47370) On macOS, prefix_a/file and prefix_b/FILE map to the same file view/file or view/FILE. This commit ensures that we test whether a view is created on a case insensitive filesystem and handle projection conflicts accordingly. * Allow tuning max_dupes for build dependencies (#48948) Up to now, Spack was allowing all build-tools that may appear in the DAG to have 2 max_dupes. This is not needed in practice for most of them, and adding them out of caution just increases grounding and concretization time. This PR makes the value of max_dupes configurable per package, and sets only a few known packages to 2 max_dupes by default. In case user needs different values, they can tune the configuration for their use case. * vtk: fix 9.4.1 concretization (#48946) * seacas: conflict 2024-06-27 with windows * vtk: fix 9.4.1 seacas dependency * cairo: add new version and update build system (#48822) * update cairo for new meson build system * update patch range. remove old conflict * style * update pango to reflect the changes in cairo * refine depends * style * add lzo depends * add +shared * non self-referential variant requireme * style * Move +shared variant back to just autotools as meson automatically handles it * clarify patch when= * update based on reviews. switch from conflicts to requires to enforce variant synchronization * refine conflicts and requires * better group build deps together * comment for meson build lower version bound * clarifying comments * clarify version ranges, enforce build_system with version ranges * style * cairo: no need to require for build_systems --------- Co-authored-by: Wouter Deconinck <wdconinc@gmail.com> * fzf: add v0.60.0, improve styling (#49059) * fd: improve documentation and styling to help newer maintainers (#49058) * direnv: add master, fix up package for better documentation (#49053) * GDAL: add v3.10.2 (#49042) * pbwt: new package (#49055) * pbwt: add v2.1, v2.0 Signed-off-by: Teague Sterling <teaguesterling@gmail.com> * [@spackbot] updating style on behalf of teaguesterling * Update package.py --------- Signed-off-by: Teague Sterling <teaguesterling@gmail.com> * py-xarray-regrid: Add new package (#48834) * Add py-xarray-regrid and required dep flox * remove boiler plate * Add missing py310 dep * py-flox, py-xarray-regrid: add type=("build", "run") to python dependency --------- Co-authored-by: Wouter Deconinck <wdconinc@gmail.com> * build(deps): bump isort in /.github/workflows/requirements/style (#48746) Bumps [isort](https://github.com/pycqa/isort) from 5.13.2 to 6.0.0. - [Release notes](https://github.com/pycqa/isort/releases) - [Changelog](https://github.com/PyCQA/isort/blob/main/CHANGELOG.md) - [Commits](https://github.com/pycqa/isort/compare/5.13.2...6.0.0) --- updated-dependencies: - dependency-name: isort dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump black from 24.10.0 to 25.1.0 in /lib/spack/docs (#48780) Bumps [black](https://github.com/psf/black) from 24.10.0 to 25.1.0. - [Release notes](https://github.com/psf/black/releases) - [Changelog](https://github.com/psf/black/blob/main/CHANGES.md) - [Commits](https://github.com/psf/black/compare/24.10.0...25.1.0) --- updated-dependencies: - dependency-name: black dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * surfer: new package (#48432) * Add waveform viewer, surfer for RTL simulations * Ran black over the code following style check failure * build(deps): bump black in /.github/workflows/requirements/style (#48779) Bumps [black](https://github.com/psf/black) from 24.10.0 to 25.1.0. - [Release notes](https://github.com/psf/black/releases) - [Changelog](https://github.com/psf/black/blob/main/CHANGES.md) - [Commits](https://github.com/psf/black/compare/24.10.0...25.1.0) --- updated-dependencies: - dependency-name: black dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * new package: jujutsu (#48231) * lis: add v2.0.28 -> v2.1.7 (#48308) * Added LIS 2.1.7 * Added LIS versions from 2.0.28 to 2.1.7 * apply black v25.1.0 (#49076) * build(deps): bump isort from 5.13.2 to 6.0.0 in /lib/spack/docs (#48747) Bumps [isort](https://github.com/pycqa/isort) from 5.13.2 to 6.0.0. - [Release notes](https://github.com/pycqa/isort/releases) - [Changelog](https://github.com/PyCQA/isort/blob/main/CHANGELOG.md) - [Commits](https://github.com/pycqa/isort/compare/5.13.2...6.0.0) --- updated-dependencies: - dependency-name: isort dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Spec.__contains__: restrict to direct build and transitive runtime deps (#49072) Co-authored-by: Massimiliano Culpo <massimiliano.culpo@gmail.com> * mochi-margo/mochi-thallium: new versions (#49037) * mochi-margo/mochi-thallium: new versions * mochi-thallium: fixing style * mochi-thallium: fixing required dependency on mochi-margo versions * Add new recipe aotriton for rocm. (#49038) * add new reciple aotriton for rocm. used for py-torch * update the git info * fix style error * fix style error * fix style error * address review comments * fix style error * update maintainers (#48295) * acts dependencies: new versions as of 2025/02/17 (#49073) This commit adds detray v0.88.1, covfie v0.12.0 and v0.12.1, as well as ACTS v37.1.0. * magma: remove cuda_arch constraint on 2.9.0+ (#49019) * plsm: new package (#48875) * Adding plsm package * [@spackbot] updating style on behalf of PhilipFackler * Removing redundant text * Add description * Add blank line * Add cuda_arch and update int64 handling * gnutls: add v3.8.9 (#49062) * gnutls: add v3.8.9 * gnutls: address super small nitpick * gnutls: fix git url * qemacs: add v6.4.1, fix +doc (#48722) * py-fastjsonschema: add 2.17 to 2.21.1; note python dependencies (#47926) * py-fastjsonschema: add 2.17 to 2.21.1; note python dependencies * py-importlib-resources: add v5.13 to 6.4 * Revert "py-importlib-resources: add v5.13 to 6.4" This reverts commit 1df208874c799b99dcfc43f13ae85f9324c59b52. --------- Signed-off-by: Shane Nehring <snehring@iastate.edu> Signed-off-by: Jonathon Anderson <anderson.jonathonm@gmail.com> Signed-off-by: Todd Gamblin <tgamblin@llnl.gov> Signed-off-by: Mathieu Taillefumier <mathieu.taillefumier@free.fr> Signed-off-by: Teague Sterling <teaguesterling@gmail.com> Signed-off-by: Howard Pritchard <howardp@lanl.gov> Signed-off-by: Justin Cook <jscook@lbl.gov> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Etienne Ndamlabin <88906611+endamlabin@users.noreply.github.com> Co-authored-by: Etienne Ndamlabin <jean-etienne.ndamlabin-mboula@inria.fr> Co-authored-by: Sreenivasa Murthy Kolam <sreenivasamurthy.kolam@amd.com> Co-authored-by: Thomas Bouvier <contact@thomas-bouvier.io> Co-authored-by: Wouter Deconinck <wdconinc@gmail.com> Co-authored-by: G-Ragghianti <33492707+G-Ragghianti@users.noreply.github.com> Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com> Co-authored-by: David Schneller <12698011+davschneller@users.noreply.github.com> Co-authored-by: Juan Miguel Carceller <22276694+jmcarcell@users.noreply.github.com> Co-authored-by: jmcarcell <jmcarcell@users.noreply.github.com> Co-authored-by: snehring <7978778+snehring@users.noreply.github.com> Co-authored-by: Buldram <buldram@proton.me> Co-authored-by: jmuddnv <143751186+jmuddnv@users.noreply.github.com> Co-authored-by: Thomas-Ulrich <ulrich@geophysik.uni-muenchen.de> Co-authored-by: Satish Balay <balay@mcs.anl.gov> Co-authored-by: Massimiliano Culpo <massimiliano.culpo@gmail.com> Co-authored-by: Filippo Spiga <spiga.filippo@gmail.com> Co-authored-by: Harmen Stoppels <me@harmenstoppels.nl> Co-authored-by: Richard Berger <rberger@lanl.gov> Co-authored-by: Jonathon Anderson <17242663+blue42u@users.noreply.github.com> Co-authored-by: Harmen Stoppels <harmenstoppels@gmail.com> Co-authored-by: Tamara Dahlgren <35777542+tldahlgren@users.noreply.github.com> Co-authored-by: Eric Berquist <727571+berquist@users.noreply.github.com> Co-authored-by: wspear <wspear@cs.uoregon.edu> Co-authored-by: wspear <wspear@users.noreply.github.com> Co-authored-by: Alec Scott <hi@alecbcs.com> Co-authored-by: John W. Parent <45471568+johnwparent@users.noreply.github.com> Co-authored-by: Todd Gamblin <tgamblin@llnl.gov> Co-authored-by: Chris Marsh <chrismarsh.c2@gmail.com> Co-authored-by: Rocco Meli <r.meli@bluemail.ch> Co-authored-by: afzpatel <122491982+afzpatel@users.noreply.github.com> Co-authored-by: psakievich <psakiev@sandia.gov> Co-authored-by: Brian Spilner <Try2Code@users.noreply.github.com> Co-authored-by: Dominic Hofer <6570912+dominichofer@users.noreply.github.com> Co-authored-by: Greg Becker <becker33@llnl.gov> Co-authored-by: danielsjensen1 <dsjense@sandia.gov> Co-authored-by: Till Ehrengruber <till.ehrengruber@cscs.ch> Co-authored-by: Henri Menke <henri@henrimenke.de> Co-authored-by: pauleonix <paul.grosse-bley@ziti.uni-heidelberg.de> Co-authored-by: Mosè Giordano <765740+giordano@users.noreply.github.com> Co-authored-by: Zack Galbreath <zack.galbreath@kitware.com> Co-authored-by: Seth R. Johnson <johnsonsr@ornl.gov> Co-authored-by: Weiqun Zhang <WeiqunZhang@lbl.gov> Co-authored-by: Taillefumier Mathieu <29380261+mtaillefumier@users.noreply.github.com> Co-authored-by: Mathieu Taillefumier <mathieu.taillefumier@free.fr> Co-authored-by: Piotr Sacharuk <107190444+PiotrSacharuk@users.noreply.github.com> Co-authored-by: eugeneswalker <eugenesunsetwalker@gmail.com> Co-authored-by: psakievich <psakievich@users.noreply.github.com> Co-authored-by: rfbgo <109985755+rfbgo@users.noreply.github.com> Co-authored-by: Felix Thaler <thaler@cscs.ch> Co-authored-by: Bernhard Kaindl <bernhardkaindl7@gmail.com> Co-authored-by: japlews <22622327+japlews@users.noreply.github.com> Co-authored-by: George Young <A-N-Other@users.noreply.github.com> Co-authored-by: Stephen Nicholas Swatman <stephen@v25.nl> Co-authored-by: Davis Herring <herring@lanl.gov> Co-authored-by: Dom Heinzeller <dom.heinzeller@icloud.com> Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja> Co-authored-by: Izaak "Zaak" Beekman <contact@izaakbeekman.com> Co-authored-by: ddement <ddement@gatech.edu> Co-authored-by: LMS Bioinformatics <bioinformatics@lms.mrc.ac.uk> Co-authored-by: Matt Thompson <matthew.thompson@nasa.gov> Co-authored-by: SXS Bot <31972027+sxs-bot@users.noreply.github.com> Co-authored-by: sxs-bot <sxs-bot@users.noreply.github.com> Co-authored-by: AMD Toolchain Support <73240730+amd-toolchain-support@users.noreply.github.com> Co-authored-by: vijay kallesh <Vijay-teekinavar.Kallesh@amd.com> Co-authored-by: Alberto Sartori <alberto.sartori@huawei.com> Co-authored-by: Alberto Invernizzi <9337627+albestro@users.noreply.github.com> Co-authored-by: Thomas Madlener <thomas.madlener@desy.de> Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi> Co-authored-by: Vinícius <viniciusvgp@gmail.com> Co-authored-by: Teague Sterling <teaguesterling@users.noreply.github.com> Co-authored-by: Shane Nehring <snehring@iastate.edu> Co-authored-by: Sergey Kosukhin <sergey.kosukhin@mpimet.mpg.de> Co-authored-by: Robert Mijakovic <robert.mijakovic@gmail.com> Co-authored-by: Paul <bryantpj@ornl.gov> Co-authored-by: Paul R. C. Kent <kentpr@ornl.gov> Co-authored-by: Vanessasaurus <814322+vsoch@users.noreply.github.com> Co-authored-by: github-actions <github-actions@users.noreply.github.com> Co-authored-by: Howard Pritchard <howardp@lanl.gov> Co-authored-by: jgraciahlrs <gracia@hlrs.de> Co-authored-by: Fernando Ayats <ayatsfer@gmail.com> Co-authored-by: Tim Haines <thaines.astro@gmail.com> Co-authored-by: renjithravindrankannath <94420380+renjithravindrankannath@users.noreply.github.com> Co-authored-by: Peter Scheibel <scheibel1@llnl.gov> Co-authored-by: alalazo <alalazo@users.noreply.github.com> Co-authored-by: Tara Drwenski <tdrwenski@users.noreply.github.com> Co-authored-by: Justin Cook <jscook@lbl.gov> Co-authored-by: jean-francois-sa <jleblancrichard@simplyanalytics.com> Co-authored-by: etiennemlb <eti.malaboeuf@gmail.com> Co-authored-by: Richard Berger <richard.berger@outlook.com> Co-authored-by: Dmitri Smirnov <dmixsmi@gmail.com> Co-authored-by: John Biddiscombe <biddisco@cscs.ch> Co-authored-by: Dave Keeshan <96727608+davekeeshan@users.noreply.github.com> Co-authored-by: Rémi Lacroix <remi.lacroix@idris.fr> Co-authored-by: Vivek Kale <11766050+vlkale@users.noreply.github.com> Co-authored-by: vlkale <vlkale@users.noreply.github.com> Co-authored-by: Marc T. Henry de Frahan <marc.henrydefrahan@nrel.gov> Co-authored-by: Robert Maaskant <RobertMaaskant@users.noreply.github.com> Co-authored-by: Matthew Lesko <matthew.w.lesko@nasa.gov> Co-authored-by: Paul Gessinger <hello@paulgessinger.com> Co-authored-by: Vicente Bolea <vicente.bolea@kitware.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Pranav Sivaraman <pranavsivaraman@gmail.com> Co-authored-by: Filippo Barbari <filippo.barbari@gmail.com> Co-authored-by: Matthieu Dorier <mdorier@anl.gov> Co-authored-by: Nai-Yuan Chiang <sorakid507@gmail.com> Co-authored-by: Cameron Rutherford <rcamruzz@amazon.com> Co-authored-by: Philip Fackler <49726797+PhilipFackler@users.noreply.github.com> Co-authored-by: dmagdavector <david.magda@vectorinstitute.ai>

Fix performance issue on macOS

fc92ee5

archspec.cpu.host() is not memoized, so compute it as less as possible.

spackbot-app bot added the core PR affects Spack core functionality label Feb 11, 2025

[@spackbot] updating style on behalf of alalazo

e6ed2e9

alalazo self-assigned this Feb 11, 2025

alalazo added the hotfix label Feb 11, 2025

Precompute the entire platform condition

cdc78c1

alalazo merged commit 5518ad9 into spack:develop Feb 11, 2025
34 of 35 checks passed

mrmundt pushed a commit to mrmundt/spack that referenced this pull request Feb 17, 2025

Fix performance issue on macOS (spack#48997)

980b84d

archspec.cpu.host() is not memoized, so compute it as less as possible. --------- Co-authored-by: alalazo <alalazo@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix performance issue on macOS #48997

Fix performance issue on macOS #48997

alalazo commented Feb 11, 2025

alalazo commented Feb 11, 2025

spackbot-app bot commented Feb 11, 2025

spackbot-app bot commented Feb 11, 2025

alalazo commented Feb 11, 2025

Fix performance issue on macOS #48997

Fix performance issue on macOS #48997

Conversation

alalazo commented Feb 11, 2025

alalazo commented Feb 11, 2025

spackbot-app bot commented Feb 11, 2025

spackbot-app bot commented Feb 11, 2025

alalazo commented Feb 11, 2025