Revert "upcxx %oneapi@2025: cxxflags add -Wno-error=missing-template-… #47512
Conversation
…arg-list-after-template-kw (spack#47503)" This reverts commit 4322cf5.
There was a problem hiding this comment.
Thanks @eugeneswalker . I agree this revert should alleviate my concerns with potential regressions introduced by #47503 . As such I have no objections to merging this as-is to restore the status quo.
However I assume that doesn't resolve the OneAPI 2025 problem that motivated the original change.
Do you plan a separate follow-on PR to address that problem, or do you want to update this change to more surgically address the problem? I suspect the original change would have probably been fine if it instead did return (None, flags, None), but I've not tested that at all.
What I had in mind was: let us restore the status quo by reverting the PR that was merged prematurely. Then, after the reversion goes through, I will follow up with a PR that will (1) correctly preserve the existing flag_handler behavior while (2) adding the flag to resolve the issue with |
There was a problem hiding this comment.
let us restore the status quo by reverting the PR that was merged prematurely. Then, after the reversion goes through, I will follow up with a PR that will (1) correctly preserve the existing flag_handler behavior while (2) adding the flag to resolve the issue with %oneapi@2025 and (3) allowing proper time for review.
Sounds good to me.
…arg-list-after-template-kw (spack#47503)" (spack#47512) This reverts commit 4322cf5.
See comment #47503 (comment)