cached_cmake: mpifc is not always defined #46861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opensdh
reviewed
Oct 8, 2024
rbberger
force-pushed
the
cached_cmake_mpifc_fix
branch
from
d7c1bf0 to
da927a2
Compare
raffenet
reviewed
Oct 8, 2024
raffenet
approved these changes
Oct 9, 2024
tldahlgren
approved these changes
Nov 18, 2024
fryeguy52
pushed a commit
to fryeguy52/spack
that referenced
this pull request
Dec 17, 2024
* cached_cmake: mpifc is not always defined * mpich: only depend on fortran when +fortran
kshea21
pushed a commit
to kshea21/spack
that referenced
this pull request
Dec 26, 2024
* cached_cmake: mpifc is not always defined * mpich: only depend on fortran when +fortran
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages like
caliperthat have optional fortran support will still try to accessmpifcviaCachedCMakePackageeven if the underlying MPI doesn't provide them (e.g.mpich~fortran). This PR makes that configuration optional.It also makes
mpichonly depend onfortranwhen+fortran.