audit: detect self-referential depends_on #42456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 2, 2024
alalazo
force-pushed
the
audit/detect-self-referential-dependencies
branch
from
334e5a3 to
3a82316
Compare
haampie
approved these changes
Feb 12, 2024
|
Hitting this issue makes code cov go up ;) |
3 tasks
mathomp4
pushed a commit
to mathomp4/spack
that referenced
this pull request
Mar 27, 2024
teaguesterling
pushed a commit
to teaguesterling/spack
that referenced
this pull request
Jun 15, 2024
kwryankrattiger
pushed a commit
to kwryankrattiger/spack
that referenced
this pull request
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #42427
This PR detects self referential dependencies in our
builtinrepository, of the form:Directives of this form may be an issue, in particular when used for virtuals, see #42427. In general, they ought to be rewritten either by specifying the virtual they provide:
or resorting to other directives (like
requiresorconflicts) which cannot add a new dependency.All the issues pointed out by this audit, when it was a draft, have been fixed already in separate PRs.