Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fastp: add v0.23.4 #38335

Merged
merged 1 commit into from
Jun 12, 2023
Merged

fastp: add v0.23.4 #38335

merged 1 commit into from
Jun 12, 2023

Conversation

alecbcs
Copy link
Member

@alecbcs alecbcs commented Jun 12, 2023

Add fastp v0.23.4.

Test Plan:
Built successfully using gcc@10.4.0 on Debian 11.

@spackbot-app
Copy link

spackbot-app bot commented Jun 12, 2023

Hi @alecbcs! I noticed that the following package(s) don't yet have maintainers:

  • fastp

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers("alecbcs")

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame fastp

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

Copy link
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the version sha256.

@tldahlgren tldahlgren merged commit f0bce3e into spack:develop Jun 12, 2023
@alecbcs alecbcs deleted the add/fastp-v0.23.4 branch June 13, 2023 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants