gitlab ci: Better tagging of "service" jobs #36846
Merged
+71
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spackbot-app
bot
added
commands
core
kwryankrattiger
previously approved these changes
Apr 13, 2023
- Tag non-rebuild jobs to target a cheaper (and more highly available) subset of runners. - Add missing resource requests to these jobs as well.
scottwittenburg
force-pushed
the
more-specific-tags-for-service-jobs
branch
from
363aef3 to
a2533c5
Compare
kwryankrattiger
approved these changes
Apr 14, 2023
|
OK to merge? |
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Apr 25, 2023
- Tag non-rebuild jobs to target a cheaper (and more highly available) subset of runners. - Add missing resource requests to these jobs as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, gitlab ci relied on service jobs (noop, cleanup, and reindex) to have the "public" tag to avoid being run on the signing runner or the gpu runners at UO. But after the ci boiler plate reduction PR, we can no longer use the reserved tags ("public", "protected", and "notary") in that way. This is fine because that wasn't really a good approach anyway.
Now the "service" tag has been added to some of the cheaper or more highly available runners (see here), and the goal of this PR is to use those runners for these jobs.
Here is an example of a reindex-job that ran on the signing runner and failed because that runner only allows the use of one particular image.