Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

heffte: update versions and arch flags #36095

Merged
merged 7 commits into from
Mar 20, 2023
Merged

heffte: update versions and arch flags #36095

merged 7 commits into from
Mar 20, 2023

Conversation

mkstoyanov
Copy link
Contributor

  • update the heFFTe repo now that it has moved to github
  • remove the pre-release versions from 4 years ago
  • deprecate the old versions
  • update the CUDA and HIP arch flags, using CUDA and HIP as CMake languages should not require extra flags
  • update the set variable name so it doesn't conflict with an internal method name

@mkstoyanov mkstoyanov mentioned this pull request Mar 13, 2023
Merged
@G-Ragghianti G-Ragghianti self-requested a review March 13, 2023 21:03
@tldahlgren tldahlgren changed the title update versions and arch flags heffte: update versions and arch flags Mar 16, 2023
@tldahlgren tldahlgren self-assigned this Mar 16, 2023
@mkstoyanov mkstoyanov force-pushed the update_heffte_develop branch from 0b1ea47 to 99fc3d1 Compare March 16, 2023 23:48
tldahlgren
tldahlgren approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed all version sha256, rest LGTM.

@tldahlgren tldahlgren enabled auto-merge (squash) March 17, 2023 02:24
@mkstoyanov
Copy link
Contributor Author

Hey @tldahlgren has the CI stalled or is it awaiting some approval?

@alalazo
Copy link
Member

alalazo commented Mar 20, 2023

@spackbot run pipeline

@spackbot-app
Copy link

spackbot-app bot commented Mar 20, 2023

I've started that pipeline for you!

@alalazo
Copy link
Member

alalazo commented Mar 20, 2023

@mkstoyanov There has been a system failure, trying to retrigger CI to finally merge this PR.

@tldahlgren tldahlgren merged commit 7e981d8 into spack:develop Mar 20, 2023
@mkstoyanov mkstoyanov deleted the update_heffte_develop branch March 20, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tldahlgren tldahlgren tldahlgren approved these changes

@G-Ragghianti G-Ragghianti Awaiting requested review from G-Ragghianti

Assignees

@tldahlgren tldahlgren

Labels
new-version update-package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkstoyanov @alalazo @tldahlgren