-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opencascade: new variants #35345
opencascade: new variants #35345
Conversation
@spackbot fix style |
Let me see if I can fix that for you! |
I was able to run spack style --fix==> Running style checks on spack
selected: isort, black, flake8, mypy
==> Modified files
var/spack/repos/builtin/packages/opencascade/package.py
==> Running isort checks
isort checks were clean
==> Running black checks
reformatted var/spack/repos/builtin/packages/opencascade/package.py
All done! ✨ 🍰 ✨
1 file reformatted.
black checks were clean
==> Running flake8 checks
flake8 checks were clean
==> Running mypy checks
Success: no issues found in 576 source files
mypy checks were clean
==> spack style checks were clean
I've updated the branch with style fixes. |
OpenCascade has several major modules and not every application needs all of them. This adds variants for the various modules. It also uodatws the 3rdparty dependency treatment.
752c131
to
abfff01
Compare
@spackbot fix style |
Let me see if I can fix that for you! |
I was able to run spack style --fix==> Running style checks on spack
selected: isort, black, flake8, mypy
==> Modified files
var/spack/repos/builtin/packages/opencascade/package.py
==> Running isort checks
isort checks were clean
==> Running black checks
reformatted var/spack/repos/builtin/packages/opencascade/package.py
All done! ✨ 🍰 ✨
1 file reformatted.
black checks were clean
==> Running flake8 checks
flake8 checks were clean
==> Running mypy checks
Success: no issues found in 578 source files
mypy checks were clean
==> spack style checks were clean
I've updated the branch with style fixes. |
FYI, the splitting into different modules is a first step towards making some of the dependencies dependent on the enabled modules. E.g. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thank you for the contribution @wdconinc! Would you like to continue work on this PR to segment out the dependencies or add it in a follow up?
I just compared my notes and there was one issue in this PR that I just fixed, but the rest is for a future PR (i.e. adding conditionals to the e.g. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
OpenCascade has several major modules and not every application needs all of them. This adds variants for the various modules.
It also updates the 3rdparty dependency treatment.