Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GDAL: don't add system paths to env vars #30229

Merged
merged 1 commit into from
Apr 25, 2022
Merged

GDAL: don't add system paths to env vars #30229

merged 1 commit into from
Apr 25, 2022

Conversation

adamjstewart
Copy link
Member

Issue reported via email:

I am having an issue with the gdal spack packaging. It is generating module files that put /usr/lib64 near the front of LD_LIBRARY_PATH, which hides any library that exists elsewhere but also has a version in /usr/lib64.

The problem occurs when any of the gdal dependencies are in packages.yaml from /usr/lib64. (e.g. json-c, libtiff, xz). When their library paths get added, they hide other libraries that might also have versions in /usr/lib64.

robertkb
robertkb reviewed Apr 21, 2022
View reviewed changes
Copy link
Contributor

@robertkb robertkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm the email complainer. It works for me.

@adamjstewart
Copy link
Member Author

@spackbot run pipeline

@spackbot-app
Copy link

spackbot-app bot commented Apr 23, 2022

I've started that pipeline for you!

@alalazo alalazo merged commit f37e07a into spack:develop Apr 25, 2022
@adamjstewart adamjstewart deleted the packages/gdal branch April 25, 2022 13:41
tgamblin pushed a commit that referenced this pull request Apr 25, 2022
@adamjstewart @tgamblin
GDAL: don't add system paths to env vars (#30229)
a761ba0
trws pushed a commit to trws/spack that referenced this pull request Apr 29, 2022
@adamjstewart @trws
GDAL: don't add system paths to env vars (spack#30229)
75c8dd3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertkb robertkb robertkb left review comments

@alalazo alalazo alalazo approved these changes

Assignees
No one assigned
Labels
update-package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamjstewart @alalazo @robertkb