Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xyce: add 'plugin' variant #28698

Merged
merged 1 commit into from
Feb 1, 2022
Merged

xyce: add 'plugin' variant #28698

merged 1 commit into from
Feb 1, 2022

Conversation

kuberry
Copy link
Contributor

@kuberry kuberry commented Jan 31, 2022

Adds the variant plugin which controls the CMake variable Xyce_PLUGIN_SUPPORT.

@kuberry kuberry requested review from sethrj and alalazo January 31, 2022 23:43
sethrj
sethrj approved these changes Feb 1, 2022
View reviewed changes
Copy link
Contributor

@sethrj sethrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@alalazo alalazo merged commit bff5d25 into spack:develop Feb 1, 2022
@kuberry
Copy link
Contributor Author

kuberry commented Feb 1, 2022

Thanks @sethrj and @alalazo!

@kuberry kuberry deleted the xyce_add_plugin branch February 1, 2022 14:43
RikkiButler20 pushed a commit to RikkiButler20/spack that referenced this pull request Feb 1, 2022
@kuberry @RikkiButler20
xyce: add 'plugin' variant (spack#28698)
49df535
RikkiButler20 pushed a commit to RikkiButler20/spack that referenced this pull request Feb 8, 2022
@kuberry @RikkiButler20
xyce: add 'plugin' variant (spack#28698)
e5c613a
EthanS94 pushed a commit to EthanS94/spack that referenced this pull request Feb 17, 2022
@kuberry @EthanS94
xyce: add 'plugin' variant (spack#28698)
fb5e8ec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethrj sethrj sethrj approved these changes

@alalazo alalazo Awaiting requested review from alalazo

Assignees
No one assigned
Labels
conflicts dependencies new-variant update-package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kuberry @sethrj @alalazo