spectre: allow disabling debug symbols #28511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsvu
force-pushed
the
packages/spectre
branch
from
4770a82 to
602a45b
Compare
alalazo
approved these changes
Jan 28, 2022
|
Going to merge since it's been pending review for 9 days + it's from the package maintainer (and from Spack perspective LGTM) |
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Feb 1, 2022
* spectre: allow disabling debug symbols * spectre: fix PCH builds * spectre: support builds with shared libs
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Feb 1, 2022
* spectre: allow disabling debug symbols * spectre: fix PCH builds * spectre: support builds with shared libs
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Feb 8, 2022
* spectre: allow disabling debug symbols * spectre: fix PCH builds * spectre: support builds with shared libs
EthanS94
pushed a commit
to EthanS94/spack
that referenced
this pull request
Feb 17, 2022
* spectre: allow disabling debug symbols * spectre: fix PCH builds * spectre: support builds with shared libs
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Mar 23, 2022
* spectre: allow disabling debug symbols * spectre: fix PCH builds * spectre: support builds with shared libs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.