-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CD: Package Index #11665
CD: Package Index #11665
Conversation
86fe733
to
7ad5cb3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nitpick and one major request: can we not check packages.json into the Spack repo? The CI should just run it.
removed it already, accidentally pushed |
ok can we remove initial spaces from shebangs? |
7ad5cb3
to
51c1e7a
Compare
huh! clumsy f1ngers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing this docker image provides a listing of packages... available for installation from the built-in repo? Is that right?
In any case, this all looks OK to me. I might make a pass on some of this after further simplifying #11621, just to make sure all of our docker stuff is consistent.
Wonderful! Yes, this provides a nginx image with static files for all packages as shown in #11652 |
@opadron I already pushed a first image manually to |
@ax3l Done! But, it looks like something isn't working quite right. Here's some log output that I see after hitting packages.spack.io a few times:
|
Taking a closer look, it seems like there isn't supposed to be a landing page, and the default page was just left unmodified? I'm not familiar with the API this server is supposed to serve, but e.g.: packages.spack.io/z/zlib.json seems to work just fine. |
Yes, we didn't add one yet and consider adding a little search frontend later on, such as https://github.com/Homebrew/formulae.brew.sh For the API itself a landing page is not needed, but will look more professional once we add one. The package index API is as simple as: The corresponding shields.io API (badges/shields#3536) for badges/shields will then be as simple as: |
51c1e7a
to
d65c778
Compare
@opadron I pushed the endpoint change to include |
Build the docker image for the new package index REST API on each merge/push to develop and master.
d65c778
to
2a139fe
Compare
@ax3l: it’s approved and I think you have merge rights :) |
Okay, I just wasn't sure if self-merge is fine :) |
Build the docker image for the new package index REST API on each merge/push to develop and master.
Build the docker image for the new package index REST API on each merge/push to develop and master.
Build the docker image for the new package index REST API on each merge/push to develop and master.
Follow-up to: #11652
Manual Build Instructions
Here is how to build the image for the service manually/locally.
Now the server is started at http://localhost:8080