radiuss packages update from radiuss-spack-configs #1402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@adrienbernede would it be possible to break these changes out into a few single package PRs? That would greatly help in reviewing and diagnosing what's breaking in CI. |
Merged
Contributor
Author
|
@alecbcs Gitlab CI was passing, waiting for new run. Style fixed. |
alecbcs
requested changes
Oct 1, 2025
Member
alecbcs
left a comment
alecbcs
left a comment
There was a problem hiding this comment.
Couple of quick suggestions. Otherwise this PR looks mostly good to me.
Use utility function to define -D option in CMake. Require fortran compiler only when fortran support is ON. Co-authored-by: Alec Scott <hi@alecbcs.com>
spackbot-triage
bot
requested review from
adayton1,
davidbeckingsale,
kab163 and
trws
adrienbernede
commented
Nov 17, 2025
This was referenced Nov 17, 2025
1 task
Contributor
Author
|
@alecbcs I think this is ready. Just need to wait for you to be back from SC ;) |
This was referenced Nov 21, 2025
alecbcs
approved these changes
Nov 21, 2025
Member
alecbcs
left a comment
alecbcs
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks @adrienbernede!
m-fila
pushed a commit
to m-fila/spack-packages
that referenced
this pull request
Nov 22, 2025
* Apply changes from local RADIUSS packages * Complete update from local specs * Fix style * Add missing import * Revert adding new versions of caliper * Fix blt version constraints in RAJA package * Other version constraints fixes * remove trailing whitespaces * Apply suggestions from code review Use utility function to define -D option in CMake. Require fortran compiler only when fortran support is ON. Co-authored-by: Alec Scott <hi@alecbcs.com> * Fix style * Fix syntax * Really fix syntax * Fix style * In Cached CMake build system: rocm path = llvm-amdgpu prefix * Apply suggestions from code review * Fix style: unused import --------- Co-authored-by: Alec Scott <hi@alecbcs.com>
mkrack
pushed a commit
to mkrack/spack-packages
that referenced
this pull request
Dec 23, 2025
* Apply changes from local RADIUSS packages * Complete update from local specs * Fix style * Add missing import * Revert adding new versions of caliper * Fix blt version constraints in RAJA package * Other version constraints fixes * remove trailing whitespaces * Apply suggestions from code review Use utility function to define -D option in CMake. Require fortran compiler only when fortran support is ON. Co-authored-by: Alec Scott <hi@alecbcs.com> * Fix style * Fix syntax * Really fix syntax * Fix style * In Cached CMake build system: rocm path = llvm-amdgpu prefix * Apply suggestions from code review * Fix style: unused import --------- Co-authored-by: Alec Scott <hi@alecbcs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates radiuss packages with some changes: