Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix errors with creating dimension rows #888

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Fix errors with creating dimension rows #888

merged 3 commits into from
Jun 25, 2024

Conversation

jjnesbitt
Copy link
Collaborator

@jjnesbitt jjnesbitt commented Jun 24, 2024 •
edited
Loading

This fixes the following issues:

  1. There was a typo which caused compiler_name to be used for both the compiler_name and compiler_version columns. I'll manually fix these incorrect rows.
  2. It seems that runners may re-register themselves under the same name multiple times to gitlab. This means there will be multiple runners with the same name, which violates a unique constraint that was present. This has been removed.

mvandenburgh
mvandenburgh previously approved these changes Jun 25, 2024
View reviewed changes
@jjnesbitt jjnesbitt merged commit f089aaf into main Jun 25, 2024
14 checks passed
@jjnesbitt jjnesbitt deleted the 870-hotfix branch June 25, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvandenburgh mvandenburgh mvandenburgh left review comments

@zackgalbreath zackgalbreath Awaiting requested review from zackgalbreath

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjnesbitt @mvandenburgh