Add django webhook handler to save job traces to opensearch #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlamanna
force-pushed
the
add-django-webhook-handler
branch
from
3e0f97d
to
282698f
Compare
jjnesbitt
reviewed
Dec 5, 2023
danlamanna
force-pushed
the
add-django-webhook-handler
branch
from
6391762
to
561221a
Compare
danlamanna
commented
Dec 7, 2023
danlamanna
commented
Dec 7, 2023
danlamanna
commented
Dec 7, 2023
danlamanna
force-pushed
the
add-django-webhook-handler
branch
2 times, most recently
from
11ed4af
to
879a456
Compare
danlamanna
force-pushed
the
add-django-webhook-handler
branch
7 times, most recently
from
1f55208
to
587b2c9
Compare
danlamanna
force-pushed
the
add-django-webhook-handler
branch
from
587b2c9
to
f4616ed
Compare
danlamanna
force-pushed
the
add-django-webhook-handler
branch
from
f4616ed
to
704b58c
Compare
jjnesbitt
reviewed
Jan 3, 2024
jjnesbitt
reviewed
Jan 3, 2024
danlamanna
force-pushed
the
add-django-webhook-handler
branch
from
c361217
to
42690d0
Compare
jjnesbitt
previously approved these changes
Jan 3, 2024
jjnesbitt
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a k8s service to host our django application internally to handle webhook requests for saving job traces. In the near future I think we should aim to consolidate our FastAPI apps to be similar endpoints under django. At the moment this PR functions but has a few question marks. It should be ready for general feedback.