Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build timing script and image versions #691

Merged
merged 3 commits into from
Nov 1, 2023
Merged

Conversation

jjnesbitt
Copy link
Collaborator

There are a couple of things that are causing the analytics DB to not contain the added fields from #635

  1. I forgot to add the @contextmanager decorator to the get_job_artifacts_file function. The lack of this decorator should have caused sentry errors that would point to the issue. However, that didn't happen because...
  2. Due to the fallout of Add new fields to analytics database #635 regarding version collision, the hastily made follow-up PR Bump versions for build timing pods #690 didn't actually bump the version of upload-build-timings that was used in the build timing webhook. So events that were being sent to the webhook were still using the old version of the script, and not adding in those fields.

@mvandenburgh
Copy link
Member

@jjnesbitt
Copy link
Collaborator Author

Do you need to bump this image version as well? fix-upload-build-timing/k8s/production/custom/build-timing-processor/deployments.yaml#L26

Yes, good catch

@jjnesbitt jjnesbitt merged commit 59234ad into main Nov 1, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants