Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reusable spack terraform module + staging deployment #386

Merged
merged 5 commits into from
Feb 10, 2023

Conversation

mvandenburgh
Copy link
Member

No description provided.

@mvandenburgh mvandenburgh force-pushed the spack-tf-module branch 6 times, most recently from 0901daf to c7750d5 Compare February 9, 2023 04:02
I copied most of the github provider resources from the Flux docs, and
didn't realize that the purpose of this particular resource is to set
the default branch of the github repo - which we don't need, and don't
want because we might want a seperate branch for staging.
@mvandenburgh mvandenburgh marked this pull request as ready for review February 9, 2023 17:12
Copy link
Collaborator

@jjnesbitt jjnesbitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Looks good overall, just a few questions/comments.

terraform/staging/main.tf Show resolved Hide resolved
terraform/production/main.tf Show resolved Hide resolved
terraform/staging/main.tf Show resolved Hide resolved
@mvandenburgh mvandenburgh merged commit bee3564 into main Feb 10, 2023
@mvandenburgh mvandenburgh deleted the spack-tf-module branch February 10, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants