Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only using mini in workflow. name accordingly #960

Merged

Conversation

BradleySappington
Copy link
Collaborator

stop populating "full" cache filename as we are only using "mini"

@york-stsci
Copy link
Collaborator

The change looks reasonable. As I understand it it, this PR is expected to fail testing until merged into develop? I'd like to specifically confirm that here before approving it.

@BradleySappington
Copy link
Collaborator Author

current cache checks will fail here, correct, however once I run them again in develop they should pass.

@BradleySappington
Copy link
Collaborator Author

Its the same update we did in STPSF

Copy link
Collaborator

@york-stsci york-stsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted in main thread, looks good.

@BradleySappington BradleySappington merged commit f74578c into spacetelescope:develop Feb 14, 2025
2 of 3 checks passed
@BradleySappington BradleySappington deleted the cache_filename branch February 14, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants