Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cal_step status keyword for clean_flicker_noise #328

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

tapastro
Copy link
Collaborator

Addresses JP-3639

This PR adds the cal_step keyword for the newly added step clean_flicker_noise.

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • run jwst regression tests with this branch installed ("git+https://github.com/<fork>/stdatamodels@<branch>")
news fragment change types...
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

@tapastro tapastro requested a review from a team as a code owner September 17, 2024 14:20
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.44%. Comparing base (f78fb11) to head (1996b18).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #328   +/-   ##
=======================================
  Coverage   66.44%   66.44%           
=======================================
  Files         102      102           
  Lines        5439     5439           
=======================================
  Hits         3614     3614           
  Misses       1825     1825           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Schema change looks good. Would you add a changelog fragment?

Copy link
Collaborator

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tapastro
Copy link
Collaborator Author

💨 🏁

@tapastro tapastro merged commit 97fb9d4 into spacetelescope:main Sep 17, 2024
18 of 19 checks passed
@tapastro tapastro deleted the clean-flicker-step-status branch September 17, 2024 14:24
@melanieclarke
Copy link

Thanks @tapastro! I forgot this change would be needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants