Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare for rename to main #247

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Jan 17, 2024

This PR updates the CI and docs to refer to a renamed "main" branch.

As no downstream package appears to reference a specific branch for stdatamodels (and instead uses the default branch) we should be able to:

  • rename the default branch to "main"
  • merge this PR

It's possible codecov may need to be updated to use "main" (if it's not using the default branch).

Github does quite a number of helpful things when the branch is renamed (see https://github.com/github/renaming#renaming-existing-branches) so if acceptable I would propose we rename the branch, merge this PR, and deal with any fallout (although I do not expect any).

Checklist

  • added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

@braingram braingram added the no-changelog-entry-needed Trivial change that doesn't need an entry in the change log label Jan 17, 2024
@braingram braingram marked this pull request as ready for review January 17, 2024 14:50
@braingram braingram requested a review from a team as a code owner January 17, 2024 14:50
Copy link
Collaborator

@zacharyburnett zacharyburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@nden nden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (master@1f2acf6). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #247   +/-   ##
=========================================
  Coverage          ?   64.84%           
=========================================
  Files             ?      103           
  Lines             ?     5694           
  Branches          ?        0           
=========================================
  Hits              ?     3692           
  Misses            ?     2002           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram merged commit 051be5f into spacetelescope:main Jan 22, 2024
22 checks passed
@braingram braingram deleted the rename_to_main branch January 22, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed Trivial change that doesn't need an entry in the change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants