Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for asdf data duplication issue with fits #105

Merged
merged 3 commits into from
Nov 29, 2022

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Nov 17, 2022

See asdf issue asdf-format/asdf#1232

To summarize the issue, resaving an asdf in fits file breaks the link between hdu
items and arrays within the asdf tree. This results in inclusion of array data as
internal blocks in the asdf tree and a (sometimes substantial) increase in the size
of the tree. The test added here checks that the asdf tree stored in the 'ASDF' hdu
does not change size on a resave.

This test is currently skipped as it will fail with the current asdf version.

Checklist

  • added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

@braingram braingram marked this pull request as ready for review November 29, 2022 16:31
@nden nden closed this Nov 29, 2022
@nden nden reopened this Nov 29, 2022
@nden
Copy link
Collaborator

nden commented Nov 29, 2022

Closed and opened to restart the tests

@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Base: 83.78% // Head: 83.78% // No change to project coverage 👍

Coverage data is based on head (1d558fb) compared to base (f934400).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #105   +/-   ##
=======================================
  Coverage   83.78%   83.78%           
=======================================
  Files          10       10           
  Lines        1714     1714           
=======================================
  Hits         1436     1436           
  Misses        278      278           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nden nden merged commit 11721d8 into spacetelescope:master Nov 29, 2022
@braingram braingram deleted the bug/fits_data_duplication branch July 7, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants