Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inverse wcs bbox #314

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Inverse wcs bbox #314

wants to merge 4 commits into from

Conversation

nden
Copy link
Collaborator

@nden nden commented Oct 30, 2024

This is part of the work for AL-852: using the bounding_box in the inverse transforms.
It requires spacetelescope/gwcs#498 to be merged

Follow up PRs are spacetelescope/jwst#8554 and spacetelescope/romancal#1273

Closes #

This PR addresses ...

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • run regression tests with this branch installed ("git+https://github.com/<fork>/stcal@<branch>")
news fragment change types...
  • changes/<PR#>.apichange.rst: change to public API
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change

@nden nden requested a review from a team as a code owner October 30, 2024 12:10
@nden nden marked this pull request as draft October 30, 2024 12:10
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.35%. Comparing base (60bd3b8) to head (19ba5b9).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #314      +/-   ##
==========================================
+ Coverage   86.21%   86.35%   +0.14%     
==========================================
  Files          47       49       +2     
  Lines        8812     8905      +93     
==========================================
+ Hits         7597     7690      +93     
  Misses       1215     1215              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kmacdonald-stsci
Copy link
Collaborator

Needs a change log fragment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants