Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support python 3.13 #300

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

support python 3.13 #300

wants to merge 3 commits into from

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Oct 8, 2024

This PR adds support for python 3.13 and adds 3.13 testing to the CI.

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • run regression tests with this branch installed ("git+https://github.com/<fork>/stcal@<branch>")
news fragment change types...
  • changes/<PR#>.apichange.rst: change to public API
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.35%. Comparing base (60bd3b8) to head (419a208).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #300      +/-   ##
==========================================
+ Coverage   86.21%   86.35%   +0.14%     
==========================================
  Files          47       49       +2     
  Lines        8812     8905      +93     
==========================================
+ Hits         7597     7690      +93     
  Misses       1215     1215              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram
Copy link
Collaborator Author

Blocked by #301

@braingram
Copy link
Collaborator Author

Rebased to include #303 to test it with python 3.13

@braingram braingram marked this pull request as ready for review October 10, 2024 17:13
@braingram braingram requested a review from a team as a code owner October 10, 2024 17:13
@braingram braingram marked this pull request as draft October 10, 2024 17:14
@braingram
Copy link
Collaborator Author

Converted this back to draft. The build with 3.13 failed due to failure to build a wheel for scikit-image:
https://github.com/spacetelescope/stcal/actions/runs/11278541799/job/31367250216?pr=300#step:7:997
It looks like they don't have a 3.13 release yet:
https://pypi.org/project/scikit-image/#files
I don't think was previously failing so I'll try to re-run the job but it probably makes sense to wait until they have a release with 3.13 wheels.

@WilliamJamieson
Copy link
Collaborator

WilliamJamieson commented Oct 30, 2024

Converted this back to draft. The build with 3.13 failed due to failure to build a wheel for scikit-image: spacetelescope/stcal/actions/runs/11278541799/job/31367250216?pr=300#step:7:997 It looks like they don't have a 3.13 release yet: pypi.org/project/scikit-image#files I don't think was previously failing so I'll try to re-run the job but it probably makes sense to wait until they have a release with 3.13 wheels.

scikit-image, added support in scikit-image/scikit-image#7565 and wheels as part of scikit-image/scikit-image#7571, both of which have appeared in version 0.25.0rc1. That pre-release version includes Python 3.13 wheels, so I have temporarily forced the installation of the pre-release when using 3.13. According to scikit-image/scikit-image#7596 (comment) the release 0.25 will have support for Python 3.13 and seems like it should occur soon.

If we are comfortable using the pre-release for now (I believe it will pull the release once that comes out), I think this PR is ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants