Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin roman_datamodels>=0.22.0 and stcal>=1.10.0, and remove rad pin #1520

Merged

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Nov 15, 2024

Tasks

  • request a review from someone specific, to avoid making the maintainers review every PR
  • add a build milestone, i.e. 24Q4_B15 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly
news fragment change types...
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change
  • changes/<PR#>.docs.rst
  • changes/<PR#>.stpipe.rst
  • changes/<PR#>.associations.rst
  • changes/<PR#>.scripts.rst
  • changes/<PR#>.mosaic_pipeline.rst
  • changes/<PR#>.patch_match.rst

steps

  • changes/<PR#>.dq_init.rst
  • changes/<PR#>.saturation.rst
  • changes/<PR#>.refpix.rst
  • changes/<PR#>.linearity.rst
  • changes/<PR#>.dark_current.rst
  • changes/<PR#>.jump_detection.rst
  • changes/<PR#>.ramp_fitting.rst
  • changes/<PR#>.assign_wcs.rst
  • changes/<PR#>.flatfield.rst
  • changes/<PR#>.photom.rst
  • changes/<PR#>.flux.rst
  • changes/<PR#>.source_detection.rst
  • changes/<PR#>.tweakreg.rst
  • changes/<PR#>.skymatch.rst
  • changes/<PR#>.outlier_detection.rst
  • changes/<PR#>.resample.rst
  • changes/<PR#>.source_catalog.rst

@zacharyburnett zacharyburnett self-assigned this Nov 15, 2024
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Nov 15, 2024
@zacharyburnett zacharyburnett added no-changelog-entry-needed and removed dependencies Pull requests that update a dependency file labels Nov 15, 2024
@zacharyburnett zacharyburnett added this to the 25Q1_B16 milestone Nov 15, 2024
@zacharyburnett zacharyburnett changed the title pin roman_datamodels>=0.22.0 and remove rad pin pin roman_datamodels>=0.22.0 and rad>=0.22.0 Nov 15, 2024
@zacharyburnett zacharyburnett changed the title pin roman_datamodels>=0.22.0 and rad>=0.22.0 pin roman_datamodels>=0.22.0 and remove rad pin Nov 15, 2024
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.68%. Comparing base (14d5f82) to head (1bee970).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1520   +/-   ##
=======================================
  Coverage   76.68%   76.68%           
=======================================
  Files         120      120           
  Lines        7832     7832           
=======================================
  Hits         6006     6006           
  Misses       1826     1826           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zacharyburnett zacharyburnett changed the title pin roman_datamodels>=0.22.0 and remove rad pin pin roman_datamodels>=0.22.0 and stcal>1.9.0, and remove rad pin Nov 15, 2024
@zacharyburnett zacharyburnett changed the title pin roman_datamodels>=0.22.0 and stcal>1.9.0, and remove rad pin pin roman_datamodels>=0.22.0 and stcal>=1.9.0, and remove rad pin Nov 15, 2024
@zacharyburnett zacharyburnett marked this pull request as ready for review November 15, 2024 15:42
@zacharyburnett zacharyburnett requested a review from a team as a code owner November 15, 2024 15:42
pyproject.toml Outdated Show resolved Hide resolved
Co-authored-by: Brett Graham <brettgraham@gmail.com>
@zacharyburnett zacharyburnett changed the title pin roman_datamodels>=0.22.0 and stcal>=1.9.0, and remove rad pin pin roman_datamodels>=0.22.0 and stcal>=1.10.0, and remove rad pin Nov 15, 2024
@braingram
Copy link
Collaborator

There was some discussion of adding upper pins for other dependencies (drizzle, tweakwcs, etc).

drizzle 2.0.0 is already out (and producing warnings in the test runs) so I'm not sure if there's much of a benefit to adding a pin.

I'd say let's not try something new by adding a bunch of extra pins (beyond what's already in this PR) for this release but perhaps discuss it for the next one. @schlafly how does that sound to you?

@braingram
Copy link
Collaborator

One more suggestion. I vote for adding a <3.13 here:

requires-python = ">=3.10"

for the release since scikit image has not yet released a 3.13 compatible version (so we don't have a 3.13 compatible stcal, etc).

Copy link
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You and Brett know best; this looks good to me.

@zacharyburnett
Copy link
Collaborator Author

One more suggestion. I vote for adding a <3.13 here:

requires-python = ">=3.10"

for the release since scikit image has not yet released a 3.13 compatible version (so we don't have a 3.13 compatible stcal, etc).

stcal already has a pin for <3.13 so that should propagate here

@zacharyburnett zacharyburnett merged commit 00b5b22 into spacetelescope:main Nov 15, 2024
30 of 31 checks passed
@zacharyburnett zacharyburnett deleted the pin/roman_datamodels branch November 15, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file no-changelog-entry-needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants