-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pin roman_datamodels>=0.22.0
and stcal>=1.10.0
, and remove rad
pin
#1520
pin roman_datamodels>=0.22.0
and stcal>=1.10.0
, and remove rad
pin
#1520
Conversation
roman_datamodels>=0.22.0
and remove rad
pinroman_datamodels>=0.22.0
and rad>=0.22.0
6cd83ec
to
da4c4a0
Compare
roman_datamodels>=0.22.0
and rad>=0.22.0
roman_datamodels>=0.22.0
and remove rad
pin
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1520 +/- ##
=======================================
Coverage 76.68% 76.68%
=======================================
Files 120 120
Lines 7832 7832
=======================================
Hits 6006 6006
Misses 1826 1826 ☔ View full report in Codecov by Sentry. |
roman_datamodels>=0.22.0
and remove rad
pinroman_datamodels>=0.22.0
and stcal>1.9.0
, and remove rad
pin
roman_datamodels>=0.22.0
and stcal>1.9.0
, and remove rad
pinroman_datamodels>=0.22.0
and stcal>=1.9.0
, and remove rad
pin
Co-authored-by: Brett Graham <brettgraham@gmail.com>
roman_datamodels>=0.22.0
and stcal>=1.9.0
, and remove rad
pinroman_datamodels>=0.22.0
and stcal>=1.10.0
, and remove rad
pin
There was some discussion of adding upper pins for other dependencies (drizzle, tweakwcs, etc). drizzle 2.0.0 is already out (and producing warnings in the test runs) so I'm not sure if there's much of a benefit to adding a pin. I'd say let's not try something new by adding a bunch of extra pins (beyond what's already in this PR) for this release but perhaps discuss it for the next one. @schlafly how does that sound to you? |
One more suggestion. I vote for adding a Line 5 in 14d5f82
for the release since scikit image has not yet released a 3.13 compatible version (so we don't have a 3.13 compatible stcal, etc). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You and Brett know best; this looks good to me.
|
Tasks
24Q4_B15
(use the latest build if not sure)no-changelog-entry-needed
)changes/
:echo "changed something" > changes/<PR#>.<changetype>.rst
(see below for change types)docs/
pageokify_regtests
to update the truth filesnews fragment change types...
changes/<PR#>.general.rst
: infrastructure or miscellaneous changechanges/<PR#>.docs.rst
changes/<PR#>.stpipe.rst
changes/<PR#>.associations.rst
changes/<PR#>.scripts.rst
changes/<PR#>.mosaic_pipeline.rst
changes/<PR#>.patch_match.rst
steps
changes/<PR#>.dq_init.rst
changes/<PR#>.saturation.rst
changes/<PR#>.refpix.rst
changes/<PR#>.linearity.rst
changes/<PR#>.dark_current.rst
changes/<PR#>.jump_detection.rst
changes/<PR#>.ramp_fitting.rst
changes/<PR#>.assign_wcs.rst
changes/<PR#>.flatfield.rst
changes/<PR#>.photom.rst
changes/<PR#>.flux.rst
changes/<PR#>.source_detection.rst
changes/<PR#>.tweakreg.rst
changes/<PR#>.skymatch.rst
changes/<PR#>.outlier_detection.rst
changes/<PR#>.resample.rst
changes/<PR#>.source_catalog.rst