Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit autoupdate #354

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

@pre-commit-ci pre-commit-ci bot requested a review from a team as a code owner June 24, 2024 19:55
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 94eb348 to 9eaf04f Compare July 1, 2024 20:38
@PaulHuwe
Copy link
Collaborator

PaulHuwe commented Jul 2, 2024

@zacharyburnett Can you investigate the failed test in this PR?

@zacharyburnett
Copy link
Collaborator

zacharyburnett commented Jul 3, 2024

ah, just looks like linting from what I assume are new rules from this version update:

tests/test_models.py:482:12: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
    |
480 |     pixearea = utils.mk_pixelarea(shape=(8, 8))
481 |     assert pixearea.meta.reftype == "AREA"
482 |     assert type(pixearea.meta.photometry.pixelarea_steradians) == u.Quantity
    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ E721
483 |     assert type(pixearea.meta.photometry.pixelarea_arcsecsq) == u.Quantity
484 |     assert pixearea.data.dtype == np.float32
    |

tests/test_models.py:483:12: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
    |
481 |     assert pixearea.meta.reftype == "AREA"
482 |     assert type(pixearea.meta.photometry.pixelarea_steradians) == u.Quantity
483 |     assert type(pixearea.meta.photometry.pixelarea_arcsecsq) == u.Quantity
    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ E721
484 |     assert pixearea.data.dtype == np.float32
    |

it doesn't like type() ==

updates:
- [github.com/pre-commit/pre-commit-hooks: v4.5.0 → v4.6.0](pre-commit/pre-commit-hooks@v4.5.0...v4.6.0)
- [github.com/codespell-project/codespell: v2.2.6 → v2.3.0](codespell-project/codespell@v2.2.6...v2.3.0)
- [github.com/asottile/pyupgrade: v3.15.1 → v3.16.0](asottile/pyupgrade@v3.15.1...v3.16.0)
- [github.com/astral-sh/ruff-pre-commit: v0.2.2 → v0.5.0](astral-sh/ruff-pre-commit@v0.2.2...v0.5.0)
- [github.com/psf/black: 24.2.0 → 24.4.2](psf/black@24.2.0...24.4.2)
- [github.com/PyCQA/bandit: 1.7.7 → 1.7.9](PyCQA/bandit@1.7.7...1.7.9)
@zacharyburnett zacharyburnett enabled auto-merge (squash) July 3, 2024 18:15
@zacharyburnett zacharyburnett merged commit a96a2dc into main Jul 3, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants