RCAL-822 Improve Schema Info Test #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #344 +/- ##
==========================================
- Coverage 97.56% 97.23% -0.33%
==========================================
Files 30 32 +2
Lines 2788 3079 +291
==========================================
+ Hits 2720 2994 +274
- Misses 68 85 +17 ☔ View full report in Codecov by Sentry. |
for more information, see https://pre-commit.ci
|
Do you understand the test failure? |
Yeah - it is because I didn't repoint to my RAD branch. Once RAD is released, I will re-run the tests. |
…aulHuwe/roman_datamodels into RCAL-789_ImproveSchemaInfoTest
ddavis-stsci
approved these changes
May 3, 2024
| @@ -3,6 +3,8 @@ | |||
|
|
|||
| - Adds test to ensure that the base ``common`` keyword groups exist within the ``schema.info`` tree. [#338] | |||
|
|
|||
| - Pleaced the previous test for ``schema_info`` with something more robust. [#344] | |||
|
|
|||
There was a problem hiding this comment.
Pleaced? maybe Replaced?
PaulHuwe
commented
May 3, 2024
|
Added regtest to ensure it would not affect the repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves RCAL-822
Closes #
This PR replaces the previous test for schema_info with something more robust.
Checklist
CHANGES.rstunder the corresponding subsection