Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add WCS to L2 and L3 models #302

Merged
merged 4 commits into from
Jan 22, 2024
Merged

add WCS to L2 and L3 models #302

merged 4 commits into from
Jan 22, 2024

Conversation

nden
Copy link
Collaborator

@nden nden commented Jan 10, 2024

Resolves RCAL-749

Closes #1060

This PR addresses ...

Checklist

@nden nden requested review from WilliamJamieson and a team as code owners January 10, 2024 15:13
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3b242ed) 97.15% compared to head (92d1ed4) 97.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #302      +/-   ##
==========================================
+ Coverage   97.15%   97.19%   +0.03%     
==========================================
  Files          28       29       +1     
  Lines        2533     2564      +31     
==========================================
+ Hits         2461     2492      +31     
  Misses         72       72              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@WilliamJamieson WilliamJamieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some of the comparison utilities need to be updated to accommodate the GWCS objects. It maybe as simple as updating

elif isinstance(value1, Model):
assert_model_equal(value1, value2)
to isinstance(value1, (Model, gwcs.<type>))

Copy link
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nden nden merged commit 2706ac1 into spacetelescope:main Jan 22, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants