RCAL-695 generalize attribute assignment and creation #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perrygreenfield
requested review from
WilliamJamieson and
a team
as code owners
perrygreenfield
force-pushed
the
newassign
branch
from
907777a
to
ffedf69
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #284 +/- ##
==========================================
+ Coverage 96.98% 97.04% +0.06%
==========================================
Files 29 28 -1
Lines 2485 2504 +19
==========================================
+ Hits 2410 2430 +20
+ Misses 75 74 -1 ☔ View full report in Codecov by Sentry. |
perrygreenfield
force-pushed
the
newassign
branch
from
5140b85
to
a227a31
Compare
4 tasks
|
Can you add a PLWishMaster link to passed RCAL regression tests with this? |
|
I ran the regression tests here: |
WilliamJamieson
suggested changes
Oct 26, 2023
perrygreenfield
force-pushed
the
newassign
branch
from
4ca4108
to
2a5c47c
Compare
WilliamJamieson
approved these changes
Nov 16, 2023
WilliamJamieson
force-pushed
the
newassign
branch
from
842cc52
to
e53431f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves RCAL-695
Closes #54
This PR addresses allows new node attributes to be created using dot notation so long as the attribute is consistent with the schema (e.g., an explicit property or matches a patternProperty).
It also enables validation of the created attribute's value, as well as validating object instances assigned to existing attributes.
Checklist
CHANGES.rstunder the corresponding subsection