Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cal-step maker to include resample #243

Merged

Conversation

WilliamJamieson
Copy link
Contributor

@WilliamJamieson WilliamJamieson commented Jul 19, 2023

This PR adds support for spacetelescope/rad#295.

Checklist

  • Added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • updated relevant documentation
  • Passed romancal regression testing on Jenkins / PLWishMaster. Link: https://plwishmaster.stsci.edu:8081/job/RT/job/romancal/XXX/ This adds a non-required entry which is not used by Romancal currently. Meaning this should have no effect on the regression tests.

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@6080b6d). Click here to learn what that means.
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head d5f588f differs from pull request most recent head 4ff3297. Consider uploading reports for the commit 4ff3297 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #243   +/-   ##
=======================================
  Coverage        ?   96.74%           
=======================================
  Files           ?       29           
  Lines           ?     2399           
  Branches        ?        0           
=======================================
  Hits            ?     2321           
  Misses          ?       78           
  Partials        ?        0           
Impacted Files Coverage Δ
src/roman_datamodels/maker_utils/_common_meta.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@WilliamJamieson WilliamJamieson force-pushed the feature/calstep_resample branch 4 times, most recently from d5f588f to a6417a6 Compare July 20, 2023 16:36
@WilliamJamieson WilliamJamieson marked this pull request as ready for review July 20, 2023 16:39
@WilliamJamieson WilliamJamieson requested a review from a team as a code owner July 20, 2023 16:39
@WilliamJamieson WilliamJamieson enabled auto-merge (squash) July 20, 2023 18:19
@WilliamJamieson WilliamJamieson merged commit 4e6db1e into spacetelescope:main Jul 20, 2023
13 checks passed
@WilliamJamieson WilliamJamieson deleted the feature/calstep_resample branch July 20, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants