Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use ValidationError from asdf.exceptions instead of jsonschema #234

Merged
merged 3 commits into from
Jul 10, 2023

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Jul 6, 2023

By using asdf.exceptions.ValidationError asdf will be free to make this error hopefully more useful and to untie it from jsonschema.

Checklist

passed all except for known failure test_one_group_small_buffer_fit_ols[none] see spacetelescope/romancal#769

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (c0a084d) 94.47% compared to head (cc0835a) 94.47%.

❗ Current head cc0835a differs from pull request most recent head f7a972e. Consider uploading reports for the commit f7a972e to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #234   +/-   ##
=======================================
  Coverage   94.47%   94.47%           
=======================================
  Files          23       23           
  Lines        1628     1628           
=======================================
  Hits         1538     1538           
  Misses         90       90           
Impacted Files Coverage Δ
src/roman_datamodels/datamodels/_core.py 89.67% <100.00%> (ø)
src/roman_datamodels/stnode/_node.py 87.97% <100.00%> (ø)
src/roman_datamodels/validate.py 93.75% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@WilliamJamieson
Copy link
Contributor

I would like to see this change; however, everyone should agree that this is the way to proceed.

@braingram
Copy link
Collaborator Author

Regression tests run:
https://plwishmaster.stsci.edu:8081/job/RT/job/Roman-Developers-Pull-Requests/278/

passed all except for known failure test_one_group_small_buffer_fit_ols[none] see spacetelescope/romancal#769

@braingram braingram marked this pull request as ready for review July 10, 2023 16:26
@braingram braingram requested review from a team and WilliamJamieson as code owners July 10, 2023 16:26
Copy link
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WilliamJamieson WilliamJamieson merged commit ac6623e into spacetelescope:main Jul 10, 2023
13 checks passed
@braingram braingram deleted the no_jsonschema branch July 10, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants