-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use ValidationError from asdf.exceptions instead of jsonschema #234
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #234 +/- ##
=======================================
Coverage 94.47% 94.47%
=======================================
Files 23 23
Lines 1628 1628
=======================================
Hits 1538 1538
Misses 90 90
☔ View full report in Codecov by Sentry. |
I would like to see this change; however, everyone should agree that this is the way to proceed. |
Regression tests run: passed all except for known failure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
By using asdf.exceptions.ValidationError asdf will be free to make this error hopefully more useful and to untie it from jsonschema.
Checklist
CHANGES.rst
under the corresponding subsectionpassed all except for known failure
test_one_group_small_buffer_fit_ols[none]
see spacetelescope/romancal#769