Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-1911: Bump asdf==2.7.3 in requirements-sdp.txt #5787

Conversation

jdavies-st
Copy link
Collaborator

Pulls in the bugfix release asdf 2.7.3 into requirements-sdp.txt. Previously, the asdf library was writing out unreadable FITS files for numpy arrays that were views over a larger arrays and were stored in as AsdfInFITS.

Resolves #5699 / JP-1911

@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #5787 (03dd57b) into master (3057780) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5787   +/-   ##
=======================================
  Coverage   76.61%   76.61%           
=======================================
  Files         406      406           
  Lines       36248    36248           
=======================================
  Hits        27773    27773           
  Misses       8475     8475           
Flag Coverage Δ *Carryforward flag
nightly 76.62% <ø> (ø) Carriedforward from 3057780
unit 54.62% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3057780...03dd57b. Read the comment docs.

Copy link
Collaborator

@eslavich eslavich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdavies-st jdavies-st merged commit eb34d65 into spacetelescope:master Feb 26, 2021
@jdavies-st jdavies-st deleted the requirements-sdp-bump-asdf-version branch February 26, 2021 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datamodel I/O efficiencies causing error in copy()
2 participants