Clean up the module structure #7
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essentially all code was unnecessarily put in a
dmi
module and then reexported at the crate level. This doesn't make a whole lot of sense.All code was instead moved to live under the base crate module or whatever its relevant module was.
This is (almost) entirely an API compatible change. Due to the aforementioned reexport, all modules were used from the base crate level. Unless you specifically were referencing them by the full qualified module path, this shouldn't cause compilation issues.
Also what was in effect an integration test was in the main sourcepath instead of the
tests
folder, so that was extracted out.One change was made for visibility.
crc
was changed to be crate local. I didn't particularly see a reason why this should be exposed. This can be reverted if needed.