Skip to content

Conversation

actioninja
Copy link
Contributor

@actioninja actioninja commented Mar 12, 2023

Essentially all code was unnecessarily put in a dmi module and then reexported at the crate level. This doesn't make a whole lot of sense.

All code was instead moved to live under the base crate module or whatever its relevant module was.

This is (almost) entirely an API compatible change. Due to the aforementioned reexport, all modules were used from the base crate level. Unless you specifically were referencing them by the full qualified module path, this shouldn't cause compilation issues.
Also what was in effect an integration test was in the main sourcepath instead of the tests folder, so that was extracted out.

One change was made for visibility. crc was changed to be crate local. I didn't particularly see a reason why this should be exposed. This can be reverted if needed.

@ZeWaka ZeWaka self-requested a review March 14, 2023 01:37
@ZeWaka
Copy link
Member

ZeWaka commented Mar 14, 2023

Been meaning to look at this, sry

@ZeWaka ZeWaka merged commit 630a979 into spacestation13:master Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants