Use crc32fast for CRC calculation (+ dependency updates)
#21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the hand-rolled crc32 impl to just use
crc32fastinstead - outputs are identical. Just to make sure, I rancargo test, and the outputtests/resources/save_test.dmiis identical to that of the current master branch.Profiling showed that CRC32 calcs were a noteworthy bottleneck (albeit certainly not the worst), so I thought it wouldn't hurt to switch it out for an optimized implementation.
Also, this should avoid any extra overhead from iterators.
In addition, I updated all the dependencies.