Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vis servers #40

Merged
merged 3 commits into from
Feb 25, 2021
Merged

Vis servers #40

merged 3 commits into from
Feb 25, 2021

Conversation

Lkruitwagen
Copy link
Contributor

A PR to merge in tileservers and modelservers

Copy link
Collaborator

@margaretmz margaretmz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Do we need to include rasterio in environment.yml? Also shall we eventually just have 1 environment.yml across all teams?
  2. I noticed multiple app.py. Are we creating multiple web apps? Or just one app with multiple pages?
  3. Does it make sense to have the web app as part of /src? Do we expect user install our ml4floods package and then being able to create or the launch web apps?

@Lkruitwagen
Copy link
Contributor Author

  1. good question. I had some questions about the main environment.yml that I wanted to ask the others, so just made a separate one for now. (I think rasterio should be a conda req, and actually better just to conda install rasterio and geopandas and let conda sort the issues with gdal, fiona, geos, etc.)
  2. I think we're only making one user interface - the dashboard. But that dashboard doesn't need to be in the same place as the tileserver. Infact, we might want the tileserver to be in a different place so it can be scaled larger. Likewise the model server is currently separate but maybe we'll want it in the same place. There are also good reasons for keeping a model server separate -e.g. scaling gpus separately. Honestly this is a devops question which we can't answer until we know more about what the actual plans for this project are, so I've kept them out as microservices for now.
  3. Again, a bigger question than I can answer. The tileserver and modelserver needs the code that the others are writing, so either we mirror or import this code in other repos or we integrate it all together. I'm not sure there's a clear answer right now :/

@margaretmz
Copy link
Collaborator

margaretmz commented Feb 25, 2021

1 - I use the .yml file to create a conda environment like this conda env create -f environment.yml which is the same as creating a new conda environment then conda install all the packages but it's more convenient. Yeah it would be good for everyone to sync up on having just one environment.yml file.

2 & 3 - OK for now we can discuss offline. :)

@margaretmz margaretmz merged commit 63a2fa3 into main Feb 25, 2021
@gonzmg88 gonzmg88 deleted the vis-servers branch September 22, 2022 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants