Fix incorrect decoding of MerkleProof #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fasmat
force-pushed
the
fix-decoding-of-merkleproof
branch
from
e2b09e4 to
48dbf5a
Compare
Codecov Report
@@ Coverage Diff @@
## develop #293 +/- ##
=======================================
Coverage 69.7% 69.7%
=======================================
Files 18 18
Lines 1524 1524
=======================================
Hits 1063 1063
Misses 350 350
Partials 111 111
|
countvonzero
approved these changes
May 15, 2023
fasmat
changed the title
bors bot
pushed a commit
to spacemeshos/go-spacemesh
that referenced
this pull request
May 15, 2023
## Motivation Closes #4386 Do not merge before spacemeshos/poet#293 ## Changes This adds a regression test for the fix in spacemeshos/poet#293. In `poet` the same is tested via fuzzing. ## Test Plan n/a ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Update documentation as needed ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of spacemeshos/go-spacemesh#4386.
This fixes the incorrect implementation of the
DecodeScalemethod ofMerkleProof.Do not merge before: spacemeshos/go-scale#56