Skip to content
This repository was archived by the owner on Oct 11, 2020. It is now read-only.

Update dependencies #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

iamonuwa
Copy link
Contributor

  • All speced functionally is implemented and is working
  • Unit tests for all functions and modules
  • Integration tests for all use cases
  • Comment documentation for all modules, functions and types
  • Ready for code review

Fixes #13

@avive
Copy link
Contributor

avive commented Nov 13, 2018

iOS simulator issue on yarn ios:

Installing build/Build/Products/Debug-iphonesimulator/cosmic.app
An error was encountered processing the command (domain=NSPOSIXErrorDomain, code=22):
Failed to install the requested application
The bundle identifier of the application could not be determined.
Ensure that the application's Info.plist contains a value for CFBundleIdentifier.
Print: Entry, ":CFBundleIdentifier", Does Not Exist

@avive
Copy link
Contributor

avive commented Nov 13, 2018

everything else seems to be working ok - so let's please fix this issue - do you have access to a mac or are you on linux?

@avive
Copy link
Contributor

avive commented Nov 13, 2018

I think that yarn dist should call yarn clean-all automatically.

@avive
Copy link
Contributor

avive commented Nov 13, 2018

yarn dist hangs on os x

@tpscrpt
Copy link

tpscrpt commented Jan 1, 2019

@avive I've made a similar PR #17 could you test on iOS/x? It works good on Electron, Web and Android with that setup.

Sorry to bother! Considering getting a Hackintosh...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants