v14: Make state field optional and disallow null for state.open #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnestler
force-pushed
the
v14-make-state-optional
branch
from
012bd43 to
0ec9dd1
Compare
[breaking-change]: In v0.13 state and but state.open must be present, but state.open may be null. This doesn't provide any benefit, so v14 removed these restrictions. We can't provide full backwards compatiblity, since state.open == null is not supported in v14. To still have a json which is compatible with both v0.13 and v14 state.open must be set to either true or false.
rnestler
force-pushed
the
v14-make-state-optional
branch
from
2c207c8 to
62a5154
Compare
|
@dbrgn I think I'll do a 0.8 release after this one, since the most important bits of the v14 support are in place now. |
dbrgn
approved these changes
Apr 30, 2021
|
@rnestler yeah, makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v0.13 state and but state.open must be present, but state.open may be
null. This doesn't provide any benefit, so v14 removed these
restrictions.
We can't provide full backwards compatiblity, since state.open == null
is not supported in v14.
To still have a json which is compatible with both v0.13 and v14
state.open must be set to either true or false.
Checklist
[breaking-change]somewhere in the commit message