Skip to content

Release v0.6.0 #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 26, 2018
Merged

Release v0.6.0 #74

merged 1 commit into from
Jan 26, 2018

Conversation

dbrgn
Copy link
Collaborator

@dbrgn dbrgn commented Jan 25, 2018

No description provided.

@dbrgn dbrgn requested a review from rnestler January 25, 2018 15:03
- [changed] Minimal required Rust version 1.20.0 (#68)
- [changed] Update `log` crate to version 0.4
- [changed] Update `log` crate to version 0.4 (#70)
- [changed] Use an enum (`IssueReportChannel`) for the `issue_report_channels`
field (#4)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This links to the issue, but don't we usually link to the PR?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it doesn't really matter since they are both linked :) Also, before creating the PR there is no pull request number yet 😉

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also why does GitHub create new issues with such low numbers? Did they somehow get missing? Or was this due to our abuse of changing issues to PRs with the CLI tool?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I think that issue is actually that old.

Copy link
Member

@rnestler rnestler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from my nagging about linking to the issue and not the PR it looks good to me 🌈

@dbrgn dbrgn merged commit 8e1823e into master Jan 26, 2018
@dbrgn dbrgn deleted the release-0.6.0 branch January 26, 2018 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants