Map System Code Refactor #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed unused property TileRef.TileSize. Removed unused property TileRef.Tile, made the field public with the same name. Made the TileRef struct readonly. Removed property TileRef.TileDef. Removed property TileRef.LocalPos. Renamed GridTile to GridIndices. Implemented IEquatable on TileRef. Implemented Equality operators on TileRef. Added PublicAPI attribute to TileRef. Added doc comments to TileRef.
Added the PublicApi annotation. Made struct readonly. Filled out doc comments. Changed auto properties to readonly fields. Renamed TileId to TypeId. Added a static Empty tile to the struct. Implemented IEquatable.
Added PublicApi attribute. Implemented IEquatable. Filled out doc comments. Removed Map property.
Filled out doc comments. Added the PublicApi attribute. Implemented IEquatable.
Removed method IsValidLocation.
Removed constructors taking a MapId.
Added attribute PublicApi. Filled out doc comments.
Filled out doc comments for MapIndices. Misc refactors for both.
Added method Box2.Union. Placement manager now spawns new grids to place tiles not connected to an existing grid.
Acruid
added
Issue: Needs Cleanup
ghost
assigned 
PJB3005
pushed a commit
to space-wizards/space-station-14
that referenced
this pull request
Apr 20, 2019
* Removes static `IoCManager` service locator calls from `Robust.Shared.Map` namespace. * Misc code cleanup and filling out doc comments for Map classes. * Added Union and Intersect methods to Box2. * Any touched component was converted from static IoC calls to field injection. Sibling PR to space-wizards/RobustToolbox#796.
SweptWasTaken
pushed a commit
to SweptWasTaken/RobustToolbox
that referenced
this pull request
Jun 7, 2020
Fixed pixel aspect ratio on SMES
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IoCManagerservice locator calls fromRobust.Shared.Mapnamespace.