Entitiy Queries & TypeFactory #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Acruid
commented
Apr 8, 2019
Acruid
commented
- Fixed bug where duplicate component instances were being sent in an EntityState. This should help network traffic a bit.
- Changed how EntityQueries worked resulting in a 3x perf increase for the EntitySystemManager.Update() method. (43% -> 14% Total CPU Time, Debug Build)
- Removed the useless giant ComponentEntityQuery. It should have never existed. Use the PredicateQuery if you need complex boolean logic (hint: you won't).
- Added the new IDynamicTypeFactory to IoC for instantiating arbitrary types. This removes the need for Activator.CreateInstance() and IoCManager.InjectDependencies() anywhere in code.
- Allowed the DependencyCollection to be able to inject itself as a dependency. This is required for a very specific use case (abstract factories), DO NOT PASS AROUND THE CONTAINER AS A DEPENDENCY.
- Utilized IDynamicTypeFactory in ComponentManager as an example of its use.
…r.Update() method. Removed the useless giant list EntityQuery. Allowed the DependencyCollection to be able to inject itself as a dependency. Hopefully it won't be abused too bad. Added the new IDynamicTypeFactory to IoC for instantiating arbitrary types. This removes the need for Activator.CreateInstance() and IoCManager.InjectDependencies() anywhere in code. Utilized IDynamicTypeFactory in IComponentManager as an example of its use.
Acruid
added
Issue: Feature
ghost
assigned 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.