Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unparent transform fix. #719

Merged
merged 2 commits into from
Dec 13, 2018

Conversation

Acruid
Copy link
Contributor

@Acruid Acruid commented Dec 12, 2018

Fixed bug where Godot node is not being sync'd with SS14 transform when unparenting.

This solves the issue where sometimes a weapon dropped will be placed at 0,0 instead of the mouse location.

This also fixed the issue with CanInsert() throwing an exception (space-wizards/space-station-14#128), now it properly returns false.

@Acruid Acruid added Issue: Bug This issue is a bug report. System: Entities labels Dec 12, 2018
@ghost ghost assigned Acruid Dec 12, 2018
@ghost ghost added the W: In Progress label Dec 12, 2018
@Acruid Acruid force-pushed the 18-12-12_Fix_Unparent_Transform branch from 3b3b405 to c28c6b5 Compare December 13, 2018 02:39
@PJB3005 PJB3005 merged commit 3cd7690 into space-wizards:master Dec 13, 2018
@ghost ghost removed the W: Review label Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Bug This issue is a bug report.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants