Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI Range Check #702

Merged
merged 1 commit into from
Nov 20, 2018
Merged

UI Range Check #702

merged 1 commit into from
Nov 20, 2018

Conversation

Acruid
Copy link
Contributor

@Acruid Acruid commented Oct 30, 2018

Clients are now properly unsubscribed from entities when they move out of range. This prevents clients from being able to control entities from across the map.

@Acruid
Fixed bugs with remote closing UI windows on clients.
69ff437 
Clients are now unsubscribed from entities when they move out of range.
@ghost ghost assigned Acruid Oct 30, 2018
@ghost ghost added the W: In Progress label Oct 30, 2018
PJB3005
PJB3005 approved these changes Oct 31, 2018
View reviewed changes
Copy link
Member

@PJB3005 PJB3005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, although I would prefer if the system were more modular as to allow other closing conditions (for example, getting knocked unconscious).

@PJB3005 PJB3005 merged commit cfda72b into space-wizards:master Nov 20, 2018
@ghost ghost removed the W: Review label Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PJB3005 PJB3005 PJB3005 approved these changes

@ZoldorfTheWizard ZoldorfTheWizard Awaiting requested review from ZoldorfTheWizard

Assignees

@Acruid Acruid

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Acruid @PJB3005