Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server Console - Cumulative Feature Update #616

Merged
merged 14 commits into from
Jul 26, 2018
Merged

Server Console - Cumulative Feature Update #616

merged 14 commits into from
Jul 26, 2018

Conversation

Acruid
Copy link
Contributor

@Acruid Acruid commented Jul 23, 2018

Purpose

  • Merge ServerConsole and ClientConsoleHost shells into one system named ConsoleShell.
  • Migrate all server side commands to the new ConsoleShell system.
  • Add a PermissionGroup system, for 'ranks' like user/mod/admin/owner.
  • Track per-client permission group, allow clients to elevate permission with global 'sudo' password.
  • Changed IWritableDirProvider.Open() to return a Stream instead of a FileStream to help test-ability.

Resolves #612.

Open Questions and Pre-Merge TODOs

  • This fix is tested on the same branch it is PR'ed to.
  • I correctly commented my code.
  • This PR does not include any unnecessary .meta, .prefab or .unity (scene) changes.
  • This PR does not bring up any new compile errors.
  • This PR has been tested in editor.
  • This PR has been tested in multiplayer.

Acruid added 13 commits July 22, 2018 11:08
@Acruid
server system console now runs commands inside of ClientConsoleHost.
8f6bd63
@Acruid
Migrated the rest of the ServerConsole commands over to ClientConsole…
b3742ba 
…Host.
@Acruid
Consolidated all of the console-ish things into the `SS14.Server.Cons…
26a2a2c 
…ole` namespace.

Renamed `ConsoleManager` to `SystemConsoleManager` to better reflect its purpose.
@Acruid
Renamed ClientConsoleHost to ConsoleShell to better reflect its purpose.
c8305d3
@Acruid
Premission group yaml loading works.
adf39f1
@Acruid
Saving kinda works, we need to be able to mock the data directory.
7884001
@Acruid
PermGroupContainer tests work.
b8e2a26
@Acruid
Renamed some files, added a controller for the group system, group ch…
f6a61f5 
…ecking works.
@Acruid
Group system works.
759c806
@Acruid
Added joingame to list of user commands.
36e0fb2 
Little bit of cleanup.
@Acruid
sudo password works.
7efe4d1
@Acruid
Removed trash tests.
ec24250
@Acruid
Commented ISystemConsoleManager.
e14d2a6 
Removed useless Initialize function in ISystemConsoleManager.
Basic Formatting cleanup.
Add chat commands to permission groups.
@ghost ghost assigned Acruid Jul 23, 2018
@ghost ghost added the W: In Progress label Jul 23, 2018
@PJB3005 PJB3005 merged commit 2b69075 into space-wizards:master Jul 26, 2018
@ghost ghost removed the W: In Progress label Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PJB3005 PJB3005 PJB3005 approved these changes

@ZoldorfTheWizard ZoldorfTheWizard Awaiting requested review from ZoldorfTheWizard

Assignees

@Acruid Acruid

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Console - Feature Update
2 participants
@Acruid @PJB3005