Don't limit parallel workers in moveit2 build (#77) #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
moveit2 build on this PR took 1.5hr instead of 3! |
This is a common hack to avoid running out of memory while building a large C++ codebase. However, it's unnecessary in an era where users just need to be educated to configure `zram` on their system.
EzraBrooks
force-pushed
the
don't-limit-parallel-workers
branch
from
0e6d813
to
4edb462
Compare
Bckempa
approved these changes
Dec 28, 2023
There was a problem hiding this comment.
Check the whole org and this is the only instance of colcon executor arguments.
|
We don't have a good sense of how long GHA will take since it's just using the cached version. Should we check that (and make sure it doesn't time-out or OOM) before merging? |
|
see https://github.com/space-ros/docker/actions/runs/7350258510/job/20011595426 for the job where it passed in 1.5 hr, half the previous runtime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #77.
This is a common hack to avoid running out of memory while building a large C++ codebase. However, it's unnecessary in an era where users just need to be educated to configure
zramon their system.