Install git-lfs in space_robots image for cloning the simulation repo

[eholum]

Resolves #193

Needed post space-ros/simulation#27.

[xfiderek]

Just one idea to brainstorm: from what I can see, vcs import fails silently when lfs is missing, i.e. it does not print any warning that git-lfs is not installed. for that reason, maybe it makes sense to include git-lfs in the base space-ros docker image, to make it easier to clone simulation assets in any project without running into silent errors. What do you think?

[asimonov]

great work, I think it should be fine.

one question though... does vcstool deal with LFS repos without any extra modifications required? simulation repo is imported here:

https://github.com/space-ros/docker/blob/main/space_robots/Dockerfile#L86

[eholum]

maybe it makes sense to include git-lfs in the base space-ros docker image

Ah, I do like the idea. Though I think the goal should be to actively discourage doing any kind of cloning during builds of a docker image. Ideally the workspace setup happens outside of the container, or at least in a disposable layer that we copy out of. We have some open tasks there iirc.

[asimonov]

Just one idea to brainstorm: from what I can see, vcs import fails silently when lfs is missing, i.e. it does not print any warning that git-lfs is not installed. for that reason, maybe it makes sense to include git-lfs in the base space-ros docker image, to make it easier to clone simulation assets in any project without running into silent errors. What do you think?

i support this idea. now that some parts of bigger project depend on git-lfs it is better to include it in base image. it is not that big. but will save time of contributors trying to figure out what does not work and how to fix it.